mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] lib: bootstrap: fix instance of possibly mismatched pointer sizes
@ 2018-12-04  9:13 Ahmad Fatoum
  2018-12-05  7:52 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2018-12-04  9:13 UTC (permalink / raw)
  To: barebox

len was int but &len is passed to read_file(..., size_t *size),
Fix this.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 lib/bootstrap/disk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/bootstrap/disk.c b/lib/bootstrap/disk.c
index a55d5d77f4cf..fd016166e6e4 100644
--- a/lib/bootstrap/disk.c
+++ b/lib/bootstrap/disk.c
@@ -18,7 +18,7 @@ void* bootstrap_read_disk(const char *dev, const char *fstype)
 {
 	int ret;
 	void *buf;
-	int len;
+	size_t len;
 	const char *path = "/";
 
 	ret = mount(dev, fstype, path, NULL);
-- 
2.19.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] lib: bootstrap: fix instance of possibly mismatched pointer sizes
  2018-12-04  9:13 [PATCH] lib: bootstrap: fix instance of possibly mismatched pointer sizes Ahmad Fatoum
@ 2018-12-05  7:52 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2018-12-05  7:52 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Tue, Dec 04, 2018 at 10:13:18AM +0100, Ahmad Fatoum wrote:
> len was int but &len is passed to read_file(..., size_t *size),
> Fix this.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  lib/bootstrap/disk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/lib/bootstrap/disk.c b/lib/bootstrap/disk.c
> index a55d5d77f4cf..fd016166e6e4 100644
> --- a/lib/bootstrap/disk.c
> +++ b/lib/bootstrap/disk.c
> @@ -18,7 +18,7 @@ void* bootstrap_read_disk(const char *dev, const char *fstype)
>  {
>  	int ret;
>  	void *buf;
> -	int len;
> +	size_t len;
>  	const char *path = "/";
>  
>  	ret = mount(dev, fstype, path, NULL);
> -- 
> 2.19.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-05  7:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-04  9:13 [PATCH] lib: bootstrap: fix instance of possibly mismatched pointer sizes Ahmad Fatoum
2018-12-05  7:52 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox