From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH] net: lib: Make use of ETH_ALEN
Date: Thu, 6 Dec 2018 23:29:02 -0800 [thread overview]
Message-ID: <20181207072902.32049-1-andrew.smirnov@gmail.com> (raw)
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
net/lib.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/lib.c b/net/lib.c
index d4343bced..d2b33132d 100644
--- a/net/lib.c
+++ b/net/lib.c
@@ -28,13 +28,13 @@
#include <net.h>
#include <linux/ctype.h>
-int string_to_ethaddr(const char *str, u8 enetaddr[6])
+int string_to_ethaddr(const char *str, u8 enetaddr[ETH_ALEN])
{
int reg;
char *e;
if (!str || strlen(str) != 17) {
- memset(enetaddr, 0, 6);
+ memset(enetaddr, 0, ETH_ALEN);
return -EINVAL;
}
@@ -42,7 +42,7 @@ int string_to_ethaddr(const char *str, u8 enetaddr[6])
str[11] != ':' || str[14] != ':')
return -EINVAL;
- for (reg = 0; reg < 6; ++reg) {
+ for (reg = 0; reg < ETH_ALEN; ++reg) {
enetaddr[reg] = simple_strtoul(str, &e, 16);
str = e + 1;
}
@@ -50,7 +50,7 @@ int string_to_ethaddr(const char *str, u8 enetaddr[6])
return 0;
}
-void ethaddr_to_string(const u8 enetaddr[6], char *str)
+void ethaddr_to_string(const u8 enetaddr[ETH_ALEN], char *str)
{
sprintf(str, "%02x:%02x:%02x:%02x:%02x:%02x",
enetaddr[0], enetaddr[1], enetaddr[2], enetaddr[3],
--
2.19.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2018-12-07 7:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 7:29 Andrey Smirnov [this message]
2018-12-10 8:53 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207072902.32049-1-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox