* [PATCH] mfd: rave-sp: Make use of wait_on_timeout()
@ 2018-12-07 7:29 Andrey Smirnov
2018-12-10 8:53 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Andrey Smirnov @ 2018-12-07 7:29 UTC (permalink / raw)
To: barebox; +Cc: Andrey Smirnov
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
drivers/mfd/rave-sp.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/mfd/rave-sp.c b/drivers/mfd/rave-sp.c
index 469ce4cc0..cc897b122 100644
--- a/drivers/mfd/rave-sp.c
+++ b/drivers/mfd/rave-sp.c
@@ -314,7 +314,6 @@ int rave_sp_exec(struct rave_sp *sp,
unsigned char *data = __data;
int command, ret = 0;
u8 ackid;
- uint64_t start = get_time_ns();
command = sp->variant->cmd.translate(data[0]);
if (command < 0)
@@ -334,12 +333,9 @@ int rave_sp_exec(struct rave_sp *sp,
* is_timeout will implicitly poll serdev via poller
* infrastructure
*/
- while (!is_timeout(start, SECOND) && !reply.received)
- ;
-
- if (!reply.received) {
+ ret = wait_on_timeout(SECOND, reply.received);
+ if (ret) {
dev_err(dev, "Command timeout\n");
- ret = -ETIMEDOUT;
sp->reply = NULL;
}
--
2.19.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: rave-sp: Make use of wait_on_timeout()
2018-12-07 7:29 [PATCH] mfd: rave-sp: Make use of wait_on_timeout() Andrey Smirnov
@ 2018-12-10 8:53 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2018-12-10 8:53 UTC (permalink / raw)
To: Andrey Smirnov; +Cc: barebox
On Thu, Dec 06, 2018 at 11:29:32PM -0800, Andrey Smirnov wrote:
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> drivers/mfd/rave-sp.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/mfd/rave-sp.c b/drivers/mfd/rave-sp.c
> index 469ce4cc0..cc897b122 100644
> --- a/drivers/mfd/rave-sp.c
> +++ b/drivers/mfd/rave-sp.c
> @@ -314,7 +314,6 @@ int rave_sp_exec(struct rave_sp *sp,
> unsigned char *data = __data;
> int command, ret = 0;
> u8 ackid;
> - uint64_t start = get_time_ns();
>
> command = sp->variant->cmd.translate(data[0]);
> if (command < 0)
> @@ -334,12 +333,9 @@ int rave_sp_exec(struct rave_sp *sp,
> * is_timeout will implicitly poll serdev via poller
> * infrastructure
> */
> - while (!is_timeout(start, SECOND) && !reply.received)
> - ;
> -
> - if (!reply.received) {
> + ret = wait_on_timeout(SECOND, reply.received);
> + if (ret) {
> dev_err(dev, "Command timeout\n");
> - ret = -ETIMEDOUT;
> sp->reply = NULL;
> }
>
> --
> 2.19.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-10 8:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-07 7:29 [PATCH] mfd: rave-sp: Make use of wait_on_timeout() Andrey Smirnov
2018-12-10 8:53 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox