mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 4/4] of: partition: add no-fixup device tree property
Date: Fri, 7 Dec 2018 08:43:03 +0100	[thread overview]
Message-ID: <20181207074302.babciy2rcwjvh2iq@pengutronix.de> (raw)
In-Reply-To: <20181207063433.7623-4-a.fatoum@pengutronix.de>

On Fri, Dec 07, 2018 at 07:34:37AM +0100, Ahmad Fatoum wrote:
> Users can have reasons to inhibit barebox from fixing up partitions nodes
> into the kernel device tree, like if it's a boot0-partitions node, which
> doesn't have a kernel binding.
> Allow users to specify a no-fixup property to indicate so.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/mtd/partition.txt | 3 +++
>  drivers/of/partition.c                              | 9 +++++++++
>  fs/devfs-core.c                                     | 1 +
>  3 files changed, 13 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/partition.txt b/Documentation/devicetree/bindings/mtd/partition.txt
> index 4288a82437b4..a2e810276a9c 100644
> --- a/Documentation/devicetree/bindings/mtd/partition.txt
> +++ b/Documentation/devicetree/bindings/mtd/partition.txt
> @@ -4,6 +4,8 @@ In addition to the upstream binding, another property is added:
>  
>  Optional properties:
>  - partuuid : The partition UUID for this partition.
> +- no-fixup : empty property, indicates that barebox shouldn't fix up the
> +             containing node into the kernel device tree.
>  
>  Additionally, barebox also supports partitioning the eMMC boot partitions if
>  the partition table node is named appropriately:
> @@ -28,6 +30,7 @@ flash@0 {
>  emmc@1 {
>  	boot0-partitions {
>  		compatible = "fixed-partitions";
> +		no-fixup;
>  		#address-cells = <1>;
>  		#size-cells = <1>;

I am not so happy that we need an extra device tree property just to let
barebox know that it shouldn't try a fixup for the boot partitions.

In mci_register_partition() we unconditionally call
of_partitions_register_fixup() even for the boot partitions. Wouldn't it
be sufficient to just skip the call for the boot partitions?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-12-07  7:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-07  6:34 [PATCH 1/4] driver: left shift 1U instead of 1 in bitmask for consistency Ahmad Fatoum
2018-12-07  6:34 ` [PATCH 2/4] of: partition: use NULL instead of never-read argument Ahmad Fatoum
2018-12-07  6:34 ` [PATCH 3/4] of: partitions: make macro name more generic Ahmad Fatoum
2018-12-07  6:34 ` [PATCH 4/4] of: partition: add no-fixup device tree property Ahmad Fatoum
2018-12-07  7:43   ` Sascha Hauer [this message]
2018-12-07  8:38     ` Ahmad Fatoum
2018-12-10  8:39       ` Sascha Hauer
2018-12-14 15:31         ` Ahmad Fatoum
2019-05-23 15:43           ` Ahmad Fatoum
2019-05-24  6:31             ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181207074302.babciy2rcwjvh2iq@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox