[PATCH] net: lib: Make use of ETH_ALEN

[PATCH] net: lib: Make use of ETH_ALEN

[Andrey Smirnov]

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 net/lib.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/lib.c b/net/lib.c
index d4343bced..d2b33132d 100644
--- a/net/lib.c
+++ b/net/lib.c
@@ -28,13 +28,13 @@
 #include <net.h>
 #include <linux/ctype.h>
 
-int string_to_ethaddr(const char *str, u8 enetaddr[6])
+int string_to_ethaddr(const char *str, u8 enetaddr[ETH_ALEN])
 {
 	int reg;
 	char *e;
 
 	if (!str || strlen(str) != 17) {
-		memset(enetaddr, 0, 6);
+		memset(enetaddr, 0, ETH_ALEN);
 		return -EINVAL;
 	}
 
@@ -42,7 +42,7 @@ int string_to_ethaddr(const char *str, u8 enetaddr[6])
 			str[11] != ':' || str[14] != ':')
 		return -EINVAL;
 
-	for (reg = 0; reg < 6; ++reg) {
+	for (reg = 0; reg < ETH_ALEN; ++reg) {
 		enetaddr[reg] = simple_strtoul(str, &e, 16);
 		str = e + 1;
 	}
@@ -50,7 +50,7 @@ int string_to_ethaddr(const char *str, u8 enetaddr[6])
 	return 0;
 }
 
-void ethaddr_to_string(const u8 enetaddr[6], char *str)
+void ethaddr_to_string(const u8 enetaddr[ETH_ALEN], char *str)
 {
 	sprintf(str, "%02x:%02x:%02x:%02x:%02x:%02x",
 		 enetaddr[0], enetaddr[1], enetaddr[2], enetaddr[3],
-- 
2.19.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] net: lib: Make use of ETH_ALEN

[Sascha Hauer]

On Thu, Dec 06, 2018 at 11:29:02PM -0800, Andrey Smirnov wrote:
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  net/lib.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/net/lib.c b/net/lib.c
> index d4343bced..d2b33132d 100644
> --- a/net/lib.c
> +++ b/net/lib.c
> @@ -28,13 +28,13 @@
>  #include <net.h>
>  #include <linux/ctype.h>
>  
> -int string_to_ethaddr(const char *str, u8 enetaddr[6])
> +int string_to_ethaddr(const char *str, u8 enetaddr[ETH_ALEN])
>  {
>  	int reg;
>  	char *e;
>  
>  	if (!str || strlen(str) != 17) {
> -		memset(enetaddr, 0, 6);
> +		memset(enetaddr, 0, ETH_ALEN);
>  		return -EINVAL;
>  	}
>  
> @@ -42,7 +42,7 @@ int string_to_ethaddr(const char *str, u8 enetaddr[6])
>  			str[11] != ':' || str[14] != ':')
>  		return -EINVAL;
>  
> -	for (reg = 0; reg < 6; ++reg) {
> +	for (reg = 0; reg < ETH_ALEN; ++reg) {
>  		enetaddr[reg] = simple_strtoul(str, &e, 16);
>  		str = e + 1;
>  	}
> @@ -50,7 +50,7 @@ int string_to_ethaddr(const char *str, u8 enetaddr[6])
>  	return 0;
>  }
>  
> -void ethaddr_to_string(const u8 enetaddr[6], char *str)
> +void ethaddr_to_string(const u8 enetaddr[ETH_ALEN], char *str)
>  {
>  	sprintf(str, "%02x:%02x:%02x:%02x:%02x:%02x",
>  		 enetaddr[0], enetaddr[1], enetaddr[2], enetaddr[3],
> -- 
> 2.19.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox