From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] commands: boot: Remove useless code
Date: Mon, 10 Dec 2018 09:54:11 +0100 [thread overview]
Message-ID: <20181210085411.qzauw3inuim2lkbb@pengutronix.de> (raw)
In-Reply-To: <20181207072951.557-1-andrew.smirnov@gmail.com>
On Thu, Dec 06, 2018 at 11:29:51PM -0800, Andrey Smirnov wrote:
> All of those variables are already initialized in-place in the
> variable declaration section above to exactly the same values
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> commands/boot.c | 4 ----
> 1 file changed, 4 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/commands/boot.c b/commands/boot.c
> index 5d81d79ce..0257b3dd4 100644
> --- a/commands/boot.c
> +++ b/commands/boot.c
> @@ -29,10 +29,6 @@ static int do_boot(int argc, char *argv[])
> struct bootentries *entries;
> struct bootentry *entry;
>
> - verbose = 0;
> - dryrun = 0;
> - timeout = -1;
> -
> while ((opt = getopt(argc, argv, "vldmt:w:")) > 0) {
> switch (opt) {
> case 'v':
> --
> 2.19.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-12-10 8:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 7:29 Andrey Smirnov
2018-12-10 8:54 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210085411.qzauw3inuim2lkbb@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox