* [PATCH] commands: boot: Remove useless code
@ 2018-12-07 7:29 Andrey Smirnov
2018-12-10 8:54 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Andrey Smirnov @ 2018-12-07 7:29 UTC (permalink / raw)
To: barebox; +Cc: Andrey Smirnov
All of those variables are already initialized in-place in the
variable declaration section above to exactly the same values
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
commands/boot.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/commands/boot.c b/commands/boot.c
index 5d81d79ce..0257b3dd4 100644
--- a/commands/boot.c
+++ b/commands/boot.c
@@ -29,10 +29,6 @@ static int do_boot(int argc, char *argv[])
struct bootentries *entries;
struct bootentry *entry;
- verbose = 0;
- dryrun = 0;
- timeout = -1;
-
while ((opt = getopt(argc, argv, "vldmt:w:")) > 0) {
switch (opt) {
case 'v':
--
2.19.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] commands: boot: Remove useless code
2018-12-07 7:29 [PATCH] commands: boot: Remove useless code Andrey Smirnov
@ 2018-12-10 8:54 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2018-12-10 8:54 UTC (permalink / raw)
To: Andrey Smirnov; +Cc: barebox
On Thu, Dec 06, 2018 at 11:29:51PM -0800, Andrey Smirnov wrote:
> All of those variables are already initialized in-place in the
> variable declaration section above to exactly the same values
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> commands/boot.c | 4 ----
> 1 file changed, 4 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/commands/boot.c b/commands/boot.c
> index 5d81d79ce..0257b3dd4 100644
> --- a/commands/boot.c
> +++ b/commands/boot.c
> @@ -29,10 +29,6 @@ static int do_boot(int argc, char *argv[])
> struct bootentries *entries;
> struct bootentry *entry;
>
> - verbose = 0;
> - dryrun = 0;
> - timeout = -1;
> -
> while ((opt = getopt(argc, argv, "vldmt:w:")) > 0) {
> switch (opt) {
> case 'v':
> --
> 2.19.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-10 8:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-07 7:29 [PATCH] commands: boot: Remove useless code Andrey Smirnov
2018-12-10 8:54 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox