From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] led: core: Don't call get_time_us() twice
Date: Mon, 10 Dec 2018 09:54:41 +0100 [thread overview]
Message-ID: <20181210085441.wt35ingr47brdfnj@pengutronix.de> (raw)
In-Reply-To: <20181207073059.1703-1-andrew.smirnov@gmail.com>
On Thu, Dec 06, 2018 at 11:30:57PM -0800, Andrey Smirnov wrote:
> The code doesn't seem to be time-sensitive enough to warrant calling
> get_time_ns() twice instead of caching its value and using it no both
> places.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> drivers/led/core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/led/core.c b/drivers/led/core.c
> index a388e6b36..f11504ace 100644
> --- a/drivers/led/core.c
> +++ b/drivers/led/core.c
> @@ -127,12 +127,13 @@ static void led_blink_func(struct poller_struct *poller)
> struct led *led;
>
> list_for_each_entry(led, &leds, list) {
> + const uint64_t now = get_time_ns();
> int on;
>
> if (!led->blink && !led->flash)
> continue;
>
> - if (led->blink_next_event > get_time_ns()) {
> + if (led->blink_next_event > now) {
> continue;
> }
>
> @@ -140,7 +141,7 @@ static void led_blink_func(struct poller_struct *poller)
> if (on)
> on = led->max_value;
>
> - led->blink_next_event = get_time_ns() +
> + led->blink_next_event = now +
> (led->blink_states[led->blink_next_state] * MSECOND);
> led->blink_next_state = (led->blink_next_state + 1) %
> led->blink_nr_states;
> --
> 2.19.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-12-10 8:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 7:30 Andrey Smirnov
2018-12-07 7:30 ` [PATCH 2/3] led: core: Initialize blink_next_event with 0 Andrey Smirnov
2018-12-07 7:30 ` [PATCH 3/3] led: core: Make use of ARRAY_AND_SIZE Andrey Smirnov
2018-12-10 8:54 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210085441.wt35ingr47brdfnj@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox