From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/6] mci: core: Use alias as a devname by default
Date: Mon, 10 Dec 2018 10:03:05 +0100 [thread overview]
Message-ID: <20181210090304.4tz56pv3vuokfgj7@pengutronix.de> (raw)
In-Reply-To: <20181207073345.5638-1-andrew.smirnov@gmail.com>
On Thu, Dec 06, 2018 at 11:33:40PM -0800, Andrey Smirnov wrote:
> This idiom is repeatead by almost every mci driver, so move it to
> mci_of_parse() in order to reduce amount of duplicated code.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> drivers/mci/mci-core.c | 5 +++++
> 1 file changed, 5 insertions(+)
Applied, thanks
Sascha
>
> diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
> index c8d1d5e16..3efd80a8a 100644
> --- a/drivers/mci/mci-core.c
> +++ b/drivers/mci/mci-core.c
> @@ -1858,6 +1858,7 @@ void mci_of_parse_node(struct mci_host *host,
> {
> u32 bus_width;
> u32 dsr_val;
> + const char *alias;
>
> if (!IS_ENABLED(CONFIG_OFDEVICE))
> return;
> @@ -1865,6 +1866,10 @@ void mci_of_parse_node(struct mci_host *host,
> if (!host->hw_dev || !np)
> return;
>
> + alias = of_alias_get(np);
> + if (alias)
> + host->devname = xstrdup(alias);
> +
> /* "bus-width" is translated to MMC_CAP_*_BIT_DATA flags */
> if (of_property_read_u32(np, "bus-width", &bus_width) < 0) {
> /* If bus-width is missing we get the driver's default, which
> --
> 2.19.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-12-10 9:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 7:33 Andrey Smirnov
2018-12-07 7:33 ` [PATCH 2/6] mci: tegra-sdmmc: Drop explicit devname setup code Andrey Smirnov
2018-12-07 7:33 ` [PATCH 3/6] mci: dw_mmc: " Andrey Smirnov
2018-12-07 7:33 ` [PATCH 4/6] mci: omap_hsmmc: " Andrey Smirnov
2018-12-07 7:33 ` [PATCH 5/6] mci: imx-esdhc: " Andrey Smirnov
2018-12-07 7:33 ` [PATCH 6/6] mci: mxs: " Andrey Smirnov
2018-12-10 9:03 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210090304.4tz56pv3vuokfgj7@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox