From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH 3/3] video: mtl017: Make sure errno is not used as a regulator pointer
Date: Wed, 12 Dec 2018 23:10:33 -0800 [thread overview]
Message-ID: <20181213071033.30932-3-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20181213071033.30932-1-andrew.smirnov@gmail.com>
Since regulator_get() can return an errno via regulator pointer, we
need to make sure we handle that case without passing bogus pointers
around.
Add code to convert mtl017->regulator to a dummy regulator if
regulator_get() fails.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
drivers/video/mtl017.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/video/mtl017.c b/drivers/video/mtl017.c
index 085ea110b..423fb8e4f 100644
--- a/drivers/video/mtl017.c
+++ b/drivers/video/mtl017.c
@@ -244,6 +244,9 @@ static int mtl017_probe(struct device_d *dev)
mtl017->client = to_i2c_client(dev);
mtl017->regulator = regulator_get(dev, "vdd");
+ if (IS_ERR(mtl017->regulator))
+ mtl017->regulator = NULL;
+
mtl017->enable_gpio = of_get_named_gpio_flags(dev->device_node,
"enable-gpios", 0, &flags);
if (gpio_is_valid(mtl017->enable_gpio)) {
--
2.19.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-12-13 7:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 7:10 [PATCH 1/3] serial: amba-pl011: Fix regulator_get() return check Andrey Smirnov
2018-12-13 7:10 ` [PATCH 2/3] mci: Rely on NULL being a dummy regulator Andrey Smirnov
2018-12-13 7:10 ` Andrey Smirnov [this message]
2018-12-14 11:11 ` [PATCH 1/3] serial: amba-pl011: Fix regulator_get() return check Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213071033.30932-3-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox