From: Sascha Hauer <s.hauer@pengutronix.de>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/6] serial_ns16550: add raspberry pi compatible and init
Date: Thu, 13 Dec 2018 08:14:57 +0100 [thread overview]
Message-ID: <20181213071457.wrwtsd64gvrcs5qq@pengutronix.de> (raw)
In-Reply-To: <20181212141054.7513-4-r.czerwinski@pengutronix.de>
On Wed, Dec 12, 2018 at 03:10:51PM +0100, Rouven Czerwinski wrote:
> Add the compatible for the Raspberry Pi AUX UART and an init function which
> enables it via the aux register and configures the correct shift value.
>
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
> drivers/serial/serial_ns16550.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c
> index 8ddcfdbef..e872fb886 100644
> --- a/drivers/serial/serial_ns16550.c
> +++ b/drivers/serial/serial_ns16550.c
> @@ -253,6 +253,15 @@ static void ns16550_jz_init_port(struct console_device *cdev)
> ns16550_serial_init_port(cdev);
> }
>
> +static void rpi_init_port(struct console_device *cdev)
> +{
> + struct ns16550_priv *priv = to_ns16550_priv(cdev);
> +
> + writeb(0x01, 0x3f215004);
> + priv->plat.shift = 2;
> + ns16550_serial_init_port(cdev);
> +}
Please indent with tabs.
> +
> /*********** Exposed Functions **********************************/
>
> /**
> @@ -353,6 +362,11 @@ static __maybe_unused struct ns16550_drvdata tegra_drvdata = {
> .linux_console_name = "ttyS",
> };
>
> +static struct ns16550_drvdata rpi_drvdata = {
> + .init_port = rpi_init_port,
> + .linux_console_name = "ttyS",
> +};
Here aswell.
Please add a __maybe_unused like done with the other drvdata in the
driver. Otherwise we'll generate a unused warning when RPI support is
disabled.
Sascha
> +
> static int ns16550_init_iomem(struct device_d *dev, struct ns16550_priv *priv)
> {
> struct resource *iores;
> @@ -528,6 +542,12 @@ static struct of_device_id ns16550_serial_dt_ids[] = {
> .data = &jz_drvdata,
> },
> #endif
> +#if IS_ENABLED(CONFIG_MACH_RPI_COMMON)
> + {
> + .compatible = "brcm,bcm2835-aux-uart",
> + .data = &rpi_drvdata,
> + },
> +#endif
> {
> /* sentinel */
> },
> --
> 2.11.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-12-13 7:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 14:10 [PATCH 0/6] Raspberry Pi miniuart support Rouven Czerwinski
2018-12-12 14:10 ` [PATCH 1/6] mach-bcm2835/core: add clkdev for uart1 Rouven Czerwinski
2018-12-12 14:22 ` Lucas Stach
2018-12-12 14:58 ` Rouven Czerwinski
2018-12-12 14:10 ` [PATCH 2/6] serial_ns16550: handle default reg-io-width Rouven Czerwinski
2018-12-12 14:10 ` [PATCH 3/6] serial_ns16550: add raspberry pi compatible and init Rouven Czerwinski
2018-12-13 7:14 ` Sascha Hauer [this message]
2018-12-12 14:10 ` [PATCH 4/6] ARM: rpi: add NS16550 support Rouven Czerwinski
2018-12-12 14:10 ` [PATCH 5/6] bcm2837-rpi-3: choose miniuart as stdout Rouven Czerwinski
2018-12-12 14:10 ` [PATCH 6/6] doc: bcm283x: remove miniuart overlay instruction Rouven Czerwinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213071457.wrwtsd64gvrcs5qq@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=r.czerwinski@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox