mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] serial: amba-pl011: Fix regulator_get() return check
Date: Fri, 14 Dec 2018 12:11:53 +0100	[thread overview]
Message-ID: <20181214111153.oyrd5pjomj4gu2q2@pengutronix.de> (raw)
In-Reply-To: <20181213071033.30932-1-andrew.smirnov@gmail.com>

On Wed, Dec 12, 2018 at 11:10:31PM -0800, Andrey Smirnov wrote:
> NULL is used to designate a dummy regulator, so it it should be safe
> to use against regulator_enable(). Any value that would retrun true
> for IS_ERR(), OTOH, is not. Such value would also pass "if (r)" check
> without any problems.
> 
> Fix the code to use !IS_ERR() instead.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  drivers/serial/amba-pl011.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/serial/amba-pl011.c b/drivers/serial/amba-pl011.c
> index 4c4067d5b..ce40f840f 100644
> --- a/drivers/serial/amba-pl011.c
> +++ b/drivers/serial/amba-pl011.c
> @@ -185,7 +185,7 @@ static int pl011_probe(struct amba_device *dev, const struct amba_id *id)
>  	struct regulator *r;
>  
>  	r = regulator_get(&dev->dev, NULL);
> -	if (r) {
> +	if (!IS_ERR(r)) {
>  		int ret;
>  
>  		ret = regulator_enable(r);
> -- 
> 2.19.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2018-12-14 11:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13  7:10 Andrey Smirnov
2018-12-13  7:10 ` [PATCH 2/3] mci: Rely on NULL being a dummy regulator Andrey Smirnov
2018-12-13  7:10 ` [PATCH 3/3] video: mtl017: Make sure errno is not used as a regulator pointer Andrey Smirnov
2018-12-14 11:11 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181214111153.oyrd5pjomj4gu2q2@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox