From: Alexander Shiyan <shc_work@mail.ru>
To: barebox@lists.infradead.org
Subject: [PATCH V2 1/2] mfd: mc13892: MC13892_POWER_MISC bits revision
Date: Mon, 17 Dec 2018 08:51:48 +0300 [thread overview]
Message-ID: <20181217055149.15355-1-shc_work@mail.ru> (raw)
This patch revises the bits for register MC13892_POWER_MISC.
- Added definition for one missing bit (0).
- Changed the name for bit 21 for accordance with the datasheet.
- Updated affected board that uses these definitions.
- Replaced tabs with spaces for the remaining bits.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/boards/efika-mx-smartbook/board.c | 2 +-
include/mfd/mc13892.h | 23 ++++++++++++-----------
2 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boards/efika-mx-smartbook/board.c b/arch/arm/boards/efika-mx-smartbook/board.c
index d7c5681db..ec41eb8c1 100644
--- a/arch/arm/boards/efika-mx-smartbook/board.c
+++ b/arch/arm/boards/efika-mx-smartbook/board.c
@@ -79,7 +79,7 @@ static void efikamx_power_init(struct mc13xxx *mc)
/* power up the system first */
mc13xxx_reg_write(mc, MC13892_REG_POWER_MISC,
- MC13892_POWER_MISC_PWUP);
+ MC13892_POWER_MISC_GPO4ADIN);
/* Set core voltage to 1.1V */
mc13xxx_reg_read(mc, MC13892_REG_SW_0, &val);
diff --git a/include/mfd/mc13892.h b/include/mfd/mc13892.h
index 8b522391b..e9a41ba21 100644
--- a/include/mfd/mc13892.h
+++ b/include/mfd/mc13892.h
@@ -182,17 +182,18 @@
#define MC13892_MODE_1_VSDMODE (1 << 20)
/* Reg Power misc */
-#define MC13892_POWER_MISC_GPO1EN (1 << 6)
-#define MC13892_POWER_MISC_GPO1STBY (1 << 7)
-#define MC13892_POWER_MISC_GPO2EN (1 << 8)
-#define MC13892_POWER_MISC_GPO2STBY (1 << 9)
-#define MC13892_POWER_MISC_GPO3EN (1 << 10)
-#define MC13892_POWER_MISC_GPO3STBY (1 << 11)
-#define MC13892_POWER_MISC_GPO4EN (1 << 12)
-#define MC13892_POWER_MISC_GPO4STBY (1 << 13)
-#define MC13892_POWER_MISC_PWGT1SPIEN (1 << 15)
-#define MC13892_POWER_MISC_PWGT2SPIEN (1 << 16)
-#define MC13892_POWER_MISC_PWUP (1 << 21)
+#define MC13892_POWER_MISC_REGSCPEN (1 << 0)
+#define MC13892_POWER_MISC_GPO1EN (1 << 6)
+#define MC13892_POWER_MISC_GPO1STBY (1 << 7)
+#define MC13892_POWER_MISC_GPO2EN (1 << 8)
+#define MC13892_POWER_MISC_GPO2STBY (1 << 9)
+#define MC13892_POWER_MISC_GPO3EN (1 << 10)
+#define MC13892_POWER_MISC_GPO3STBY (1 << 11)
+#define MC13892_POWER_MISC_GPO4EN (1 << 12)
+#define MC13892_POWER_MISC_GPO4STBY (1 << 13)
+#define MC13892_POWER_MISC_PWGT1SPIEN (1 << 15)
+#define MC13892_POWER_MISC_PWGT2SPIEN (1 << 16)
+#define MC13892_POWER_MISC_GPO4ADIN (1 << 21)
/* Reg Power Control 2*/
#define MC13892_POWER_CONTROL_2_WDIRESET (1 << 12)
--
2.13.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2018-12-17 5:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 5:51 Alexander Shiyan [this message]
2018-12-17 5:51 ` [PATCH V2 2/2] ARM: CCMX51: Switch to multiimage support Alexander Shiyan
2018-12-17 7:00 ` Oleksij Rempel
2018-12-17 10:10 ` Sascha Hauer
2018-12-17 10:57 ` Oleksij Rempel
2018-12-17 11:22 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217055149.15355-1-shc_work@mail.ru \
--to=shc_work@mail.ru \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox