From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/4] net/e1000: Map custom error codes to more appropriate errno values
Date: Mon, 17 Dec 2018 10:42:09 +0100 [thread overview]
Message-ID: <20181217094209.al7uf2sz2z2ls5mm@pengutronix.de> (raw)
In-Reply-To: <20181213070336.26837-1-andrew.smirnov@gmail.com>
On Wed, Dec 12, 2018 at 11:03:33PM -0800, Andrey Smirnov wrote:
> A number of custom error codes used by e1000 driver will be propagated
> all the way up to generic networking code and will end up being fed to
> strerror(). As a result of that, some of the current error codes will
> result in not very helpful failure messages. For example, trying to
> ping a host on a system where access to i210's EEPROM fails results in
> the following message:
>
> barebox@ZII RDU2 Board:/ ping 192.168.53.7
> ping failed: Operation not permitted
>
> In order to make message like that one a little bit more helpful,
> change definitions of various E1000_ERR_* constants to map to a bit
> more appropriate error codes.
>
> While at it, remove E1000_ERR_MASTER_REQUESTS_PENDING and
> E1000_ERR_HOST_INTERFACE_COMMAND that are not referenced anywhere in
> the codebase.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> drivers/net/e1000/e1000.h | 24 +++++++++++-------------
> 1 file changed, 11 insertions(+), 13 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/net/e1000/e1000.h b/drivers/net/e1000/e1000.h
> index 4a1a1aa33..0a9e107c0 100644
> --- a/drivers/net/e1000/e1000.h
> +++ b/drivers/net/e1000/e1000.h
> @@ -95,19 +95,17 @@ typedef enum {
>
> /* Error Codes */
> #define E1000_SUCCESS 0
> -#define E1000_ERR_EEPROM 1
> -#define E1000_ERR_PHY 2
> -#define E1000_ERR_CONFIG 3
> -#define E1000_ERR_PARAM 4
> -#define E1000_ERR_MAC_TYPE 5
> -#define E1000_ERR_PHY_TYPE 6
> -#define E1000_ERR_NOLINK 7
> -#define E1000_ERR_TIMEOUT 8
> -#define E1000_ERR_RESET 9
> -#define E1000_ERR_MASTER_REQUESTS_PENDING 10
> -#define E1000_ERR_HOST_INTERFACE_COMMAND 11
> -#define E1000_BLK_PHY_RESET 12
> -#define E1000_ERR_SWFW_SYNC 13
> +#define E1000_ERR_EEPROM EIO
> +#define E1000_ERR_PHY EIO
> +#define E1000_ERR_CONFIG EINVAL
> +#define E1000_ERR_PARAM EINVAL
> +#define E1000_ERR_MAC_TYPE EINVAL
> +#define E1000_ERR_PHY_TYPE EINVAL
> +#define E1000_ERR_NOLINK ENETDOWN
> +#define E1000_ERR_TIMEOUT ETIMEDOUT
> +#define E1000_ERR_RESET EIO
> +#define E1000_BLK_PHY_RESET EWOULDBLOCK
> +#define E1000_ERR_SWFW_SYNC EBUSY
>
> /* PCI Device IDs */
> #define E1000_DEV_ID_82542 0x1000
> --
> 2.19.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-12-17 9:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 7:03 Andrey Smirnov
2018-12-13 7:03 ` [PATCH 2/4] net/e1000: Do not discard EEPROM error code in e1000_setup_link() Andrey Smirnov
2018-12-13 7:03 ` [PATCH 3/4] net/e1000: Use dev_err to report error Andrey Smirnov
2018-12-13 7:03 ` [PATCH 4/4] net/e1000: Only read EEPROM_INIT_CONTROL2_REG if it is needed Andrey Smirnov
2018-12-17 9:42 ` Sascha Hauer [this message]
2019-01-03 15:31 ` [PATCH 1/4] net/e1000: Map custom error codes to more appropriate errno values Roland Hieber
2019-01-04 1:47 ` Andrey Smirnov
2019-01-04 11:16 ` Roland Hieber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217094209.al7uf2sz2z2ls5mm@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox