mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org,
	"Thorsten K. Scherer" <t.scherer@eckelmann.de>
Subject: Re: [PATCH] imd: model and compatible missing in metadata
Date: Mon, 17 Dec 2018 12:31:02 +0100	[thread overview]
Message-ID: <20181217113102.kjlim22expeyz627@pengutronix.de> (raw)
In-Reply-To: <20181217141852.9c9dd9acf3072d07af8af20b@gmail.com>

On Mon, Dec 17, 2018 at 02:18:52PM +0300, Antony Pavlov wrote:
> On Thu, 13 Dec 2018 07:33:56 +0100
> "Thorsten K. Scherer" <t.scherer@eckelmann.de> wrote:
> 
> Hi!
> 
> 
> > fixes 97e81f2
> > 
> > Signed-off-by: Thorsten K. Scherer <t.scherer@eckelmann.de>
> > ---
> >  include/asm-generic/barebox.lds.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/asm-generic/barebox.lds.h b/include/asm-generic/barebox.lds.h
> > index 74d3ca4a9..decaab79a 100644
> > --- a/include/asm-generic/barebox.lds.h
> > +++ b/include/asm-generic/barebox.lds.h
> > @@ -66,7 +66,7 @@
> >  #define BAREBOX_IMD				\
> >  	KEEP(*(.barebox_imd_start))		\
> >  	KEEP(*(.barebox_imd_1*))		\
> > -	*(.barebox_imd_0*)			\
> > +	KEEP(*(.barebox_imd_0*))		\
> >  	KEEP(*(.barebox_imd_end))
> >  
> >  #if defined(CONFIG_ARCH_BAREBOX_MAX_BARE_INIT_SIZE) && \
> > -- 
> > 2.19.1
> 
> It looks like this patch has unobvious drawback.
> The bareboximd utility sees too many 'model' and 'compatible' strings in a single image, e.g.:

Now I remember what the intention was that this line looks so apparently
different from the other ones ;)

To get the compatible strings into the binary I have created imd_used().
This should be called with the symbol that should be kept in the
resulting image.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-12-17 11:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13  6:33 Thorsten K. Scherer
2018-12-13  7:20 ` Sascha Hauer
2018-12-17 11:18 ` Antony Pavlov
2018-12-17 11:31   ` Sascha Hauer [this message]
2018-12-20 12:54     ` Scherer, Thorsten
2019-01-03 11:02       ` s.hauer
2019-01-22  8:10     ` Scherer, Thorsten
2019-01-22  8:53       ` Uwe Kleine-König
2019-01-23 14:05         ` Scherer, Thorsten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181217113102.kjlim22expeyz627@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=t.scherer@eckelmann.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox