From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gYr7C-0006pX-SS for barebox@lists.infradead.org; Mon, 17 Dec 2018 11:31:16 +0000 Date: Mon, 17 Dec 2018 12:31:02 +0100 From: Sascha Hauer Message-ID: <20181217113102.kjlim22expeyz627@pengutronix.de> References: <20181213063356.19138-1-t.scherer@eckelmann.de> <20181217141852.9c9dd9acf3072d07af8af20b@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181217141852.9c9dd9acf3072d07af8af20b@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] imd: model and compatible missing in metadata To: Antony Pavlov Cc: barebox@lists.infradead.org, "Thorsten K. Scherer" On Mon, Dec 17, 2018 at 02:18:52PM +0300, Antony Pavlov wrote: > On Thu, 13 Dec 2018 07:33:56 +0100 > "Thorsten K. Scherer" wrote: > > Hi! > > > > fixes 97e81f2 > > > > Signed-off-by: Thorsten K. Scherer > > --- > > include/asm-generic/barebox.lds.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/asm-generic/barebox.lds.h b/include/asm-generic/barebox.lds.h > > index 74d3ca4a9..decaab79a 100644 > > --- a/include/asm-generic/barebox.lds.h > > +++ b/include/asm-generic/barebox.lds.h > > @@ -66,7 +66,7 @@ > > #define BAREBOX_IMD \ > > KEEP(*(.barebox_imd_start)) \ > > KEEP(*(.barebox_imd_1*)) \ > > - *(.barebox_imd_0*) \ > > + KEEP(*(.barebox_imd_0*)) \ > > KEEP(*(.barebox_imd_end)) > > > > #if defined(CONFIG_ARCH_BAREBOX_MAX_BARE_INIT_SIZE) && \ > > -- > > 2.19.1 > > It looks like this patch has unobvious drawback. > The bareboximd utility sees too many 'model' and 'compatible' strings in a single image, e.g.: Now I remember what the intention was that this line looks so apparently different from the other ones ;) To get the compatible strings into the binary I have created imd_used(). This should be called with the symbol that should be kept in the resulting image. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox