From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gZ61Y-0001XN-Hr for barebox@lists.infradead.org; Tue, 18 Dec 2018 03:26:26 +0000 Date: Tue, 18 Dec 2018 04:26:10 +0100 From: Roland Hieber Message-ID: <20181218032610.zpsxavqsbzswg3ry@pengutronix.de> References: <39d36e54718c9c5c75175e3836de5425b1f73fb3.1545034218.git-series.r.czerwinski@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <39d36e54718c9c5c75175e3836de5425b1f73fb3.1545034218.git-series.r.czerwinski@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v4 2/7] ARM: rpi: retrieve miniuart clock from firmware To: Rouven Czerwinski Cc: barebox@lists.infradead.org On Mon, Dec 17, 2018 at 09:10:40AM +0100, Rouven Czerwinski wrote: > The miniuart uses the core clock as the clock source. This clock is fixed by the > firmware to 250Mhz if enable_uart=1 is set in the config.txt file. > However a user could still choose to overclock the core frequency, > which would result in wrong baudrates computed by barebox. > Retrieve the core clock frequency from the firmware to allow all potential > firmware configurations to work with barebox. > > Signed-off-by: Rouven Czerwinski > --- > arch/arm/boards/raspberry-pi/rpi-common.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boards/raspberry-pi/rpi-common.c b/arch/arm/boards/raspberry-pi/rpi-common.c > index 490aeef..e29177d 100644 > --- a/arch/arm/boards/raspberry-pi/rpi-common.c > +++ b/arch/arm/boards/raspberry-pi/rpi-common.c > @@ -309,6 +309,13 @@ static int rpi_console_clock_init(void) > clkdev_add_physbase(clk, 0x20201000, NULL); > clkdev_add_physbase(clk, 0x3f201000, NULL); > > + clk = rpi_register_firmware_clock(BCM2835_MBOX_CLOCK_ID_CORE, > + "uart1-8250"); > + if (IS_ERR(clk)) > + return PTR_ERR(clk); > + > + clkdev_add_physbase(clk, 0x3f215040, NULL); This magic value could probably have an explaining comment somewhere next to it. - Roland > + > clk = clk_fixed("bcm2835-cs", 1 * 1000 * 1000); > clk_register_clkdev(clk, NULL, "bcm2835-cs"); > > -- > git-series 0.9.1 > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Roland Hieber | r.hieber@pengutronix.de | Pengutronix e.K. | https://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox