[PATCH 01/10] serial: clps711x: Change compatible string

[PATCH 01/10] serial: clps711x: Change compatible string

[Alexander Shiyan]

This patch changes compatible string for CLPS711X serial driver
to "cirrus,ep7209-uart" for conform with linux kernel.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 drivers/serial/serial_clps711x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/serial/serial_clps711x.c b/drivers/serial/serial_clps711x.c
index fa6342346..9a9ae24c0 100644
--- a/drivers/serial/serial_clps711x.c
+++ b/drivers/serial/serial_clps711x.c
@@ -182,7 +182,7 @@ out_err:
 }
 
 static struct of_device_id __maybe_unused clps711x_uart_dt_ids[] = {
-	{ .compatible = "cirrus,clps711x-uart", },
+	{ .compatible = "cirrus,ep7209-uart", },
 };
 
 static struct driver_d clps711x_driver = {
-- 
2.13.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 02/10] serial: clps711x: Switch to SPDX identifier

[Alexander Shiyan]

Adopt the SPDX license identifier headers to ease license compliance
management.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 drivers/serial/serial_clps711x.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/drivers/serial/serial_clps711x.c b/drivers/serial/serial_clps711x.c
index 9a9ae24c0..c21ca6510 100644
--- a/drivers/serial/serial_clps711x.c
+++ b/drivers/serial/serial_clps711x.c
@@ -1,13 +1,5 @@
-/*
- * Simple CLPS711X serial driver
- *
- * (C) Copyright 2012-2014 Alexander Shiyan <shc_work@mail.ru>
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- */
+// SPDX-License-Identifier: GPL-2.0+
+/* Author: Alexander Shiyan <shc_work@mail.ru> */
 
 #include <common.h>
 #include <malloc.h>
-- 
2.13.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 02/10] serial: clps711x: Switch to SPDX identifier

[Roland Hieber]

Hi Alexander,

On Wed, Dec 19, 2018 at 11:03:55AM +0300, Alexander Shiyan wrote:
> Adopt the SPDX license identifier headers to ease license compliance
> management.
> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  drivers/serial/serial_clps711x.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/serial/serial_clps711x.c b/drivers/serial/serial_clps711x.c
> index 9a9ae24c0..c21ca6510 100644
> --- a/drivers/serial/serial_clps711x.c
> +++ b/drivers/serial/serial_clps711x.c
> @@ -1,13 +1,5 @@
> -/*
> - * Simple CLPS711X serial driver
> - *
> - * (C) Copyright 2012-2014 Alexander Shiyan <shc_work@mail.ru>
> - *
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License as
> - * published by the Free Software Foundation; either version 2 of
> - * the License, or (at your option) any later version.
> - */
> +// SPDX-License-Identifier: GPL-2.0+
> +/* Author: Alexander Shiyan <shc_work@mail.ru> */

Your removed the "Copyright" here and replaced it with "Author", but in
some jurisdictions copyright and authorship are actually different
things, and most automated license compliance tools only look for the
string "Copyright", so your change will probably mean that your name
will not be picked up as copyright. Was this change made deliberately?

Same goes for "[PATCH 06/10] gpio: clps711x: Switch to SPDX identifier".

 - Roland

>  
>  #include <common.h>
>  #include <malloc.h>
> -- 
> 2.13.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 02/10] serial: clps711x: Switch to SPDX identifier

[Roland Hieber]

On Fri, Jan 04, 2019 at 11:46:55AM +0100, Roland Hieber wrote:
> Hi Alexander,
> 
> On Wed, Dec 19, 2018 at 11:03:55AM +0300, Alexander Shiyan wrote:
> > Adopt the SPDX license identifier headers to ease license compliance
> > management.
> > 
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> >  drivers/serial/serial_clps711x.c | 12 ++----------
> >  1 file changed, 2 insertions(+), 10 deletions(-)
> > 
> > diff --git a/drivers/serial/serial_clps711x.c b/drivers/serial/serial_clps711x.c
> > index 9a9ae24c0..c21ca6510 100644
> > --- a/drivers/serial/serial_clps711x.c
> > +++ b/drivers/serial/serial_clps711x.c
> > @@ -1,13 +1,5 @@
> > -/*
> > - * Simple CLPS711X serial driver
> > - *
> > - * (C) Copyright 2012-2014 Alexander Shiyan <shc_work@mail.ru>
> > - *
> > - * This program is free software; you can redistribute it and/or
> > - * modify it under the terms of the GNU General Public License as
> > - * published by the Free Software Foundation; either version 2 of
> > - * the License, or (at your option) any later version.
> > - */
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/* Author: Alexander Shiyan <shc_work@mail.ru> */
> 
> Your removed the "Copyright" here and replaced it with "Author", but in
> some jurisdictions copyright and authorship are actually different
> things, and most automated license compliance tools only look for the
> string "Copyright", so your change will probably mean that your name
> will not be picked up as copyright. Was this change made deliberately?
> 
> Same goes for "[PATCH 06/10] gpio: clps711x: Switch to SPDX identifier".

and "[PATCH 09/10] clocksource: clps711x: Switch to SPDX identifier".

 - Roland

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 02/10] serial: clps711x: Switch to SPDX identifier

[Alexander Shiyan]

>Пятница,  4 января 2019, 13:48 +03:00 от Roland Hieber <rhi@pengutronix.de>:
>
>On Fri, Jan 04, 2019 at 11:46:55AM +0100, Roland Hieber wrote:
>> Hi Alexander,
>> 
>> On Wed, Dec 19, 2018 at 11:03:55AM +0300, Alexander Shiyan wrote:
>> > Adopt the SPDX license identifier headers to ease license compliance
>> > management.
>> > 
>> > Signed-off-by: Alexander Shiyan < shc_work@mail.ru >
>> > ---
>> >  drivers/serial/serial_clps711x.c | 12 ++----------
>> >  1 file changed, 2 insertions(+), 10 deletions(-)
>> > 
>> > diff --git a/drivers/serial/serial_clps711x.c b/drivers/serial/serial_clps711x.c
>> > index 9a9ae24c0..c21ca6510 100644
>> > --- a/drivers/serial/serial_clps711x.c
>> > +++ b/drivers/serial/serial_clps711x.c
>> > @@ -1,13 +1,5 @@
>> > -/*
>> > - * Simple CLPS711X serial driver
>> > - *
>> > - * (C) Copyright 2012-2014 Alexander Shiyan < shc_work@mail.ru >
>> > - *
>> > - * This program is free software; you can redistribute it and/or
>> > - * modify it under the terms of the GNU General Public License as
>> > - * published by the Free Software Foundation; either version 2 of
>> > - * the License, or (at your option) any later version.
>> > - */
>> > +// SPDX-License-Identifier: GPL-2.0+
>> > +/* Author: Alexander Shiyan < shc_work@mail.ru > */
>> 
>> Your removed the "Copyright" here and replaced it with "Author", but in
>> some jurisdictions copyright and authorship are actually different
>> things, and most automated license compliance tools only look for the
>> string "Copyright", so your change will probably mean that your name
>> will not be picked up as copyright. Was this change made deliberately?
>> 
>> Same goes for "[PATCH 06/10] gpio: clps711x: Switch to SPDX identifier".
>
>and "[PATCH 09/10] clocksource: clps711x: Switch to SPDX identifier".

Everything is OK, as it was intended.

---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 03/10] serial: clps711x: Use DIV_ROUND_CLOSEST() for baudrate calculation

[Alexander Shiyan]

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 drivers/serial/serial_clps711x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/serial/serial_clps711x.c b/drivers/serial/serial_clps711x.c
index c21ca6510..863ba7dd3 100644
--- a/drivers/serial/serial_clps711x.c
+++ b/drivers/serial/serial_clps711x.c
@@ -46,7 +46,7 @@ static int clps711x_setbaudrate(struct console_device *cdev, int baudrate)
 	int divisor;
 	u32 tmp;
 
-	divisor = (clk_get_rate(s->uart_clk) / 16) / baudrate;
+	divisor = DIV_ROUND_CLOSEST(clk_get_rate(s->uart_clk), baudrate * 16);
 
 	tmp = readl(s->base + UBRLCR) & ~UBRLCR_BAUD_MASK;
 	tmp |= divisor - 1;
-- 
2.13.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 04/10] serial: clps711x: Determine device name from device tree

[Alexander Shiyan]

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 drivers/serial/serial_clps711x.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/serial/serial_clps711x.c b/drivers/serial/serial_clps711x.c
index 863ba7dd3..d4f674afd 100644
--- a/drivers/serial/serial_clps711x.c
+++ b/drivers/serial/serial_clps711x.c
@@ -124,6 +124,7 @@ static int clps711x_probe(struct device_d *dev)
 	struct clps711x_uart *s;
 	int err, id = dev->id;
 	char syscon_dev[8];
+	const char *devname;
 
 	if (dev->device_node)
 		id = of_alias_get_id(dev->device_node, "serial");
@@ -162,6 +163,14 @@ static int clps711x_probe(struct device_d *dev)
 	s->cdev.getc	= clps711x_getc;
 	s->cdev.flush	= clps711x_flush;
 	s->cdev.setbrg	= clps711x_setbaudrate;
+	s->cdev.linux_console_name = "ttyCL";
+
+	devname = of_alias_get(dev->device_node);
+	if (devname) {
+		s->cdev.devname = xstrdup(devname);
+		s->cdev.devid = DEVICE_ID_SINGLE;
+	}
+
 	clps711x_init_port(&s->cdev);
 
 	err = console_register(&s->cdev);
-- 
2.13.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 05/10] gpio: clps711x: Change compatible string

[Alexander Shiyan]

This patch changes compatible string for CLPS711X GPIO driver
to "cirrus,ep7209-gpio" for conform with linux kernel.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 drivers/gpio/gpio-clps711x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-clps711x.c b/drivers/gpio/gpio-clps711x.c
index c1ec6ab68..eef2a29e8 100644
--- a/drivers/gpio/gpio-clps711x.c
+++ b/drivers/gpio/gpio-clps711x.c
@@ -71,7 +71,7 @@ out_err:
 }
 
 static struct of_device_id __maybe_unused clps711x_gpio_dt_ids[] = {
-	{ .compatible = "cirrus,clps711x-gpio", },
+	{ .compatible = "cirrus,ep7209-gpio", },
 	{ /* sentinel */ }
 };
 
-- 
2.13.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 06/10] gpio: clps711x: Switch to SPDX identifier

[Alexander Shiyan]

Adopt the SPDX license identifier headers to ease license compliance
management.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 drivers/gpio/gpio-clps711x.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/gpio/gpio-clps711x.c b/drivers/gpio/gpio-clps711x.c
index eef2a29e8..d3d669713 100644
--- a/drivers/gpio/gpio-clps711x.c
+++ b/drivers/gpio/gpio-clps711x.c
@@ -1,11 +1,5 @@
-/*
- * Copyright (C) 2013-2014 Alexander Shiyan <shc_work@mail.ru>
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- */
+// SPDX-License-Identifier: GPL-2.0+
+/* Author: Alexander Shiyan <shc_work@mail.ru> */
 
 #include <init.h>
 #include <common.h>
-- 
2.13.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 07/10] gpio: clps711x: Use coredevice_platform_driver() macro

[Alexander Shiyan]

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 drivers/gpio/gpio-clps711x.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpio/gpio-clps711x.c b/drivers/gpio/gpio-clps711x.c
index d3d669713..946da533b 100644
--- a/drivers/gpio/gpio-clps711x.c
+++ b/drivers/gpio/gpio-clps711x.c
@@ -74,9 +74,4 @@ static struct driver_d clps711x_gpio_driver = {
 	.probe		= clps711x_gpio_probe,
 	.of_compatible	= DRV_OF_COMPAT(clps711x_gpio_dt_ids),
 };
-
-static __init int clps711x_gpio_register(void)
-{
-	return platform_driver_register(&clps711x_gpio_driver);
-}
-coredevice_initcall(clps711x_gpio_register);
+coredevice_platform_driver(clps711x_gpio_driver);
-- 
2.13.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 08/10] clocksource: clps711x: Add devicetree support

[Alexander Shiyan]

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 drivers/clocksource/clps711x.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/clocksource/clps711x.c b/drivers/clocksource/clps711x.c
index f6399e930..d9e0f795e 100644
--- a/drivers/clocksource/clps711x.c
+++ b/drivers/clocksource/clps711x.c
@@ -51,9 +51,15 @@ static int clps711x_cs_probe(struct device_d *dev)
 	return init_clock(&clps711x_cs);
 }
 
+static __maybe_unused struct of_device_id clps711x_timer_dt_ids[] = {
+	{ .compatible = "cirrus,ep7209-timer", },
+	{ }
+};
+
 static struct driver_d clps711x_cs_driver = {
 	.name = "clps711x-cs",
 	.probe = clps711x_cs_probe,
+	.of_compatible = DRV_OF_COMPAT(clps711x_timer_dt_ids),
 };
 
 static __init int clps711x_cs_init(void)
-- 
2.13.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 09/10] clocksource: clps711x: Switch to SPDX identifier

[Alexander Shiyan]

Adopt the SPDX license identifier headers to ease license compliance
management.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 drivers/clocksource/clps711x.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/clocksource/clps711x.c b/drivers/clocksource/clps711x.c
index d9e0f795e..a3070e727 100644
--- a/drivers/clocksource/clps711x.c
+++ b/drivers/clocksource/clps711x.c
@@ -1,11 +1,5 @@
-/*
- * Copyright (C) 2013 Alexander Shiyan <shc_work@mail.ru>
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 2 of
- * the License, or (at your option) any later version.
- */
+// SPDX-License-Identifier: GPL-2.0+
+/* Author: Alexander Shiyan <shc_work@mail.ru> */
 
 #include <common.h>
 #include <clock.h>
-- 
2.13.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 10/10] clocksource: clps711x: Use coredevice_platform_driver() macro

[Alexander Shiyan]

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 drivers/clocksource/clps711x.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/clocksource/clps711x.c b/drivers/clocksource/clps711x.c
index a3070e727..3df2c81e9 100644
--- a/drivers/clocksource/clps711x.c
+++ b/drivers/clocksource/clps711x.c
@@ -55,9 +55,4 @@ static struct driver_d clps711x_cs_driver = {
 	.probe = clps711x_cs_probe,
 	.of_compatible = DRV_OF_COMPAT(clps711x_timer_dt_ids),
 };
-
-static __init int clps711x_cs_init(void)
-{
-	return platform_driver_register(&clps711x_cs_driver);
-}
-coredevice_initcall(clps711x_cs_init);
+coredevice_platform_driver(clps711x_cs_driver);
-- 
2.13.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 01/10] serial: clps711x: Change compatible string

[Sascha Hauer]

On Wed, Dec 19, 2018 at 11:03:54AM +0300, Alexander Shiyan wrote:
> This patch changes compatible string for CLPS711X serial driver
> to "cirrus,ep7209-uart" for conform with linux kernel.
> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  drivers/serial/serial_clps711x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied all, thanks

Sascha

> 
> diff --git a/drivers/serial/serial_clps711x.c b/drivers/serial/serial_clps711x.c
> index fa6342346..9a9ae24c0 100644
> --- a/drivers/serial/serial_clps711x.c
> +++ b/drivers/serial/serial_clps711x.c
> @@ -182,7 +182,7 @@ out_err:
>  }
>  
>  static struct of_device_id __maybe_unused clps711x_uart_dt_ids[] = {
> -	{ .compatible = "cirrus,clps711x-uart", },
> +	{ .compatible = "cirrus,ep7209-uart", },
>  };
>  
>  static struct driver_d clps711x_driver = {
> -- 
> 2.13.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox