mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] mci: skip of_partitions_register_fixup for boot partitions
@ 2019-01-02 13:35 Ahmad Fatoum
  2019-01-03  8:17 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2019-01-02 13:35 UTC (permalink / raw)
  To: barebox

The bootN-partitions binding is barebox-specific, so it shouldn't
be fixed up into the kernel device tree.

Suggested-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/mci/mci-core.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
index c8d1d5e16474..62378913c2e5 100644
--- a/drivers/mci/mci-core.c
+++ b/drivers/mci/mci-core.c
@@ -1628,7 +1628,12 @@ static int mci_register_partition(struct mci_part *part)
 
 	if (np) {
 		of_parse_partitions(&part->blk.cdev, np);
-		of_partitions_register_fixup(&part->blk.cdev);
+
+		/* bootN-partitions binding barebox-specific, so don't register
+		 * for fixup into kernel device tree
+		 */
+		if (part->area_type != MMC_BLK_DATA_AREA_BOOT)
+			of_partitions_register_fixup(&part->blk.cdev);
 	}
 
 	return 0;
-- 
2.19.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mci: skip of_partitions_register_fixup for boot partitions
  2019-01-02 13:35 [PATCH] mci: skip of_partitions_register_fixup for boot partitions Ahmad Fatoum
@ 2019-01-03  8:17 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2019-01-03  8:17 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Wed, Jan 02, 2019 at 02:35:48PM +0100, Ahmad Fatoum wrote:
> The bootN-partitions binding is barebox-specific, so it shouldn't
> be fixed up into the kernel device tree.
> 
> Suggested-by: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/mci/mci-core.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
> index c8d1d5e16474..62378913c2e5 100644
> --- a/drivers/mci/mci-core.c
> +++ b/drivers/mci/mci-core.c
> @@ -1628,7 +1628,12 @@ static int mci_register_partition(struct mci_part *part)
>  
>  	if (np) {
>  		of_parse_partitions(&part->blk.cdev, np);
> -		of_partitions_register_fixup(&part->blk.cdev);
> +
> +		/* bootN-partitions binding barebox-specific, so don't register
> +		 * for fixup into kernel device tree
> +		 */
> +		if (part->area_type != MMC_BLK_DATA_AREA_BOOT)
> +			of_partitions_register_fixup(&part->blk.cdev);
>  	}
>  
>  	return 0;
> -- 
> 2.19.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-01-03  8:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-02 13:35 [PATCH] mci: skip of_partitions_register_fixup for boot partitions Ahmad Fatoum
2019-01-03  8:17 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox