From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mci: skip of_partitions_register_fixup for boot partitions
Date: Thu, 3 Jan 2019 09:17:12 +0100 [thread overview]
Message-ID: <20190103081712.xnrzycfnvjrix34q@pengutronix.de> (raw)
In-Reply-To: <20190102133547.16106-1-a.fatoum@pengutronix.de>
On Wed, Jan 02, 2019 at 02:35:48PM +0100, Ahmad Fatoum wrote:
> The bootN-partitions binding is barebox-specific, so it shouldn't
> be fixed up into the kernel device tree.
>
> Suggested-by: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/mci/mci-core.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
> index c8d1d5e16474..62378913c2e5 100644
> --- a/drivers/mci/mci-core.c
> +++ b/drivers/mci/mci-core.c
> @@ -1628,7 +1628,12 @@ static int mci_register_partition(struct mci_part *part)
>
> if (np) {
> of_parse_partitions(&part->blk.cdev, np);
> - of_partitions_register_fixup(&part->blk.cdev);
> +
> + /* bootN-partitions binding barebox-specific, so don't register
> + * for fixup into kernel device tree
> + */
> + if (part->area_type != MMC_BLK_DATA_AREA_BOOT)
> + of_partitions_register_fixup(&part->blk.cdev);
> }
>
> return 0;
> --
> 2.19.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-01-03 8:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 13:35 Ahmad Fatoum
2019-01-03 8:17 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103081712.xnrzycfnvjrix34q@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox