From: Sascha Hauer <s.hauer@pengutronix.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH v1 2/5] images: fix force rebuild of piggy.o
Date: Thu, 3 Jan 2019 10:06:05 +0100 [thread overview]
Message-ID: <20190103090605.3qycpb22j3nveo6p@pengutronix.de> (raw)
In-Reply-To: <20181231080725.2141-3-sam@ravnborg.org>
On Mon, Dec 31, 2018 at 09:07:22AM +0100, Sam Ravnborg wrote:
> piggy.o would be build for every time barebox was built
> This had the sideeffect that the image(s) would
> always be rebuilt despite no changes
>
> Fix this by adding piggy.o to targets
> and avoid an extra command in the rule to create .pblb files
>
> The patch includes the removal of a stray assignment
>
> Fixes: 2078438662 ("Add multi images support")
This adds multi images support, but the actual change that this patch
fixes came with 5a1a5ed253 ("ARM: images: use piggydata").
I changed that while applying.
Thanks,
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-01-03 9:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-31 8:07 [PATCH 0/5] Independent collection of patches Sam Ravnborg
2018-12-31 8:07 ` [PATCH v1 1/5] 2d-primitives: fix no previous prototype warning Sam Ravnborg
2018-12-31 8:07 ` [PATCH v1 2/5] images: fix force rebuild of piggy.o Sam Ravnborg
2019-01-03 9:06 ` Sascha Hauer [this message]
2018-12-31 8:07 ` [PATCH v1 3/5] arm: fix no prototype for barebox_arm_reset_vector() Sam Ravnborg
2019-01-04 7:27 ` Sascha Hauer
2019-01-06 20:38 ` Sam Ravnborg
2019-01-07 7:41 ` Sascha Hauer
2018-12-31 8:07 ` [PATCH v1 4/5] at91sam9263ek: fix build of of_init Sam Ravnborg
2018-12-31 8:07 ` [PATCH v1 5/5] video: mtl017: fix driver name variable Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103090605.3qycpb22j3nveo6p@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox