mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Oleksij Rempel <linux@rempel-privat.de>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: MIPS multiimabe is brocken after "Images: Add image size to built images"
Date: Thu, 3 Jan 2019 11:04:40 +0100	[thread overview]
Message-ID: <20190103100440.6fck2c5olsgfi6fd@pengutronix.de> (raw)
In-Reply-To: <33739d90-5710-b9b9-bee9-73f2d0ff1e25@rempel-privat.de>

On Sat, Dec 22, 2018 at 11:00:46AM +0100, Oleksij Rempel wrote:
> Am 22.12.18 um 10:56 schrieb Sam Ravnborg:
> > Hi Oleksij
> > 
> >> i can't build MIPS images after this patch:
> >>
> >> commit 3abeee3e45224c73245e32cb614c241cd195f1c4 (bb/master)
> >> Author: Sascha Hauer <s.hauer@pengutronix.de>
> >> Date:   Mon Dec 17 12:09:23 2018 +0100
> > 
> > Can you elaborate a little what goes wrong.
> > Does the build fail or you cannot boot barebox?
> 
> The build will fail with:
> 
>   OBJCOPYB images/start_black_swift.pblb
>   OBJCOPYB images/start_dptechnics_dpt_module.pblb
>   OBJCOPYB images/start_8devices_lima.pblb
>   OBJCOPYB images/start_tplink_mr3020.pblb
>   OBJCOPYB images/start_tplink_wdr4300.pblb
> invalid magic
> barebox/images/Makefile:68: recipe for target
> 'images/start_black_swift.pblb' failed
> make[1]: *** [images/start_black_swift.pblb] Error 1
> make[1]: *** Waiting for unfinished jobs....
> invalid magic

This is because fix_size is called on the .pblb images and fix_size
is written for ARM and doesn't recognize this as a valid image.

What we can do is to call fix_size with -i (which still causes an error
message, but no error. Would have to patch the error message away
aswell).
Another possibility would be to call fix_size only for builds which
support it (ARM).

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2019-01-03 10:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-22  9:12 Oleksij Rempel
2018-12-22  9:56 ` Sam Ravnborg
2018-12-22 10:00   ` Sam Ravnborg
2018-12-22 10:03     ` Oleksij Rempel
2018-12-31 10:07       ` Sam Ravnborg
2018-12-22 10:00   ` Oleksij Rempel
2019-01-03 10:04     ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190103100440.6fck2c5olsgfi6fd@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=linux@rempel-privat.de \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox