MIPS multiimabe is brocken after "Images: Add image size to built images"

MIPS multiimabe is brocken after "Images: Add image size to built images"

[Oleksij Rempel]

[-- Attachment #1.1.1: Type: text/plain, Size: 650 bytes --]

Hi Sascha,

i can't build MIPS images after this patch:

commit 3abeee3e45224c73245e32cb614c241cd195f1c4 (bb/master)
Author: Sascha Hauer <s.hauer@pengutronix.de>
Date:   Mon Dec 17 12:09:23 2018 +0100

    Images: Add image size to built images

    This brings back the image size written into the built images which got
    lost in the conversion to using piggydata in the PBL images.

    Fixes: 5a1a5ed253 ("ARM: images: use piggydata")

    Reported-by: Teresa Remmet <t.remmet@phytec.de>
    Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
    Tested-by: Teresa Remmet <t.remmet@phytec.de>


-- 
Regards,
Oleksij


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: MIPS multiimabe is brocken after "Images: Add image size to built images"

[Sam Ravnborg]

Hi Oleksij

> i can't build MIPS images after this patch:
> 
> commit 3abeee3e45224c73245e32cb614c241cd195f1c4 (bb/master)
> Author: Sascha Hauer <s.hauer@pengutronix.de>
> Date:   Mon Dec 17 12:09:23 2018 +0100

Can you elaborate a little what goes wrong.
Does the build fail or you cannot boot barebox?

	Sam

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: MIPS multiimabe is brocken after "Images: Add image size to built images"

[Sam Ravnborg]

On Sat, Dec 22, 2018 at 10:56:56AM +0100, Sam Ravnborg wrote:
> Hi Oleksij
> 
> > i can't build MIPS images after this patch:
> > 
> > commit 3abeee3e45224c73245e32cb614c241cd195f1c4 (bb/master)
> > Author: Sascha Hauer <s.hauer@pengutronix.de>
> > Date:   Mon Dec 17 12:09:23 2018 +0100
> 
> Can you elaborate a little what goes wrong.
> Does the build fail or you cannot boot barebox?

If I want to try to build a mips variant of barebox,
can you then recommend a toolchain to use?

Maybe one from:
https://toolchains.bootlin.com/
?

	Sam

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: MIPS multiimabe is brocken after "Images: Add image size to built images"

[Oleksij Rempel]

Am 22.12.18 um 10:56 schrieb Sam Ravnborg:
> Hi Oleksij
> 
>> i can't build MIPS images after this patch:
>>
>> commit 3abeee3e45224c73245e32cb614c241cd195f1c4 (bb/master)
>> Author: Sascha Hauer <s.hauer@pengutronix.de>
>> Date:   Mon Dec 17 12:09:23 2018 +0100
> 
> Can you elaborate a little what goes wrong.
> Does the build fail or you cannot boot barebox?

The build will fail with:

  OBJCOPYB images/start_black_swift.pblb
  OBJCOPYB images/start_dptechnics_dpt_module.pblb
  OBJCOPYB images/start_8devices_lima.pblb
  OBJCOPYB images/start_tplink_mr3020.pblb
  OBJCOPYB images/start_tplink_wdr4300.pblb
invalid magic
barebox/images/Makefile:68: recipe for target
'images/start_black_swift.pblb' failed
make[1]: *** [images/start_black_swift.pblb] Error 1
make[1]: *** Waiting for unfinished jobs....
invalid magic
invalid magic
barebox/images/Makefile:68: recipe for target
'images/start_dptechnics_dpt_module.pblb' failed
make[1]: *** [images/start_dptechnics_dpt_module.pblb] Error 1
barebox/images/Makefile:68: recipe for target
'images/start_tplink_mr3020.pblb' failed
make[1]: *** [images/start_tplink_mr3020.pblb] Error 1
invalid magic
barebox/images/Makefile:68: recipe for target
'images/start_8devices_lima.pblb' failed
make[1]: *** [images/start_8devices_lima.pblb] Error 1
invalid magic
barebox/images/Makefile:68: recipe for target
'images/start_tplink_wdr4300.pblb' failed
make[1]: *** [images/start_tplink_wdr4300.pblb] Error 1
rm images/start_black_swift.pbl
Makefile:501: recipe for target 'images' failed
make: *** [images] Error 2

-- 
Regards,
Oleksij

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: MIPS multiimabe is brocken after "Images: Add image size to built images"

[Oleksij Rempel]

Am 22.12.18 um 11:00 schrieb Sam Ravnborg:
> On Sat, Dec 22, 2018 at 10:56:56AM +0100, Sam Ravnborg wrote:
>> Hi Oleksij
>>
>>> i can't build MIPS images after this patch:
>>>
>>> commit 3abeee3e45224c73245e32cb614c241cd195f1c4 (bb/master)
>>> Author: Sascha Hauer <s.hauer@pengutronix.de>
>>> Date:   Mon Dec 17 12:09:23 2018 +0100
>>
>> Can you elaborate a little what goes wrong.
>> Does the build fail or you cannot boot barebox?
> 
> If I want to try to build a mips variant of barebox,
> can you then recommend a toolchain to use?
> 
> Maybe one from:
> https://toolchains.bootlin.com/
> ?

Mostly I use native toolchain provided by debian/ubuntu
mips-linux-gnu-gcc

As alternative i also use toolchain provided by pengutronix:
https://www.pengutronix.de/de/software/toolchain.html

https://debian.pengutronix.de/
package: oselas.toolchain-2018.12-mips-softfloat-linux-gnu

-- 
Regards,
Oleksij

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: MIPS multiimabe is brocken after "Images: Add image size to built images"

[Sam Ravnborg]

Hi Oleksij.

> > can you then recommend a toolchain to use?
> 
> Mostly I use native toolchain provided by debian/ubuntu
> mips-linux-gnu-gcc
> 
> As alternative i also use toolchain provided by pengutronix:
> https://www.pengutronix.de/de/software/toolchain.html
> 
> https://debian.pengutronix.de/
> package: oselas.toolchain-2018.12-mips-softfloat-linux-gnu

Thanks for the pointers. I never managed to take a look at this,
as I was sidetracked by something else.

	Sam

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: MIPS multiimabe is brocken after "Images: Add image size to built images"

[Sascha Hauer]

On Sat, Dec 22, 2018 at 11:00:46AM +0100, Oleksij Rempel wrote:
> Am 22.12.18 um 10:56 schrieb Sam Ravnborg:
> > Hi Oleksij
> > 
> >> i can't build MIPS images after this patch:
> >>
> >> commit 3abeee3e45224c73245e32cb614c241cd195f1c4 (bb/master)
> >> Author: Sascha Hauer <s.hauer@pengutronix.de>
> >> Date:   Mon Dec 17 12:09:23 2018 +0100
> > 
> > Can you elaborate a little what goes wrong.
> > Does the build fail or you cannot boot barebox?
> 
> The build will fail with:
> 
>   OBJCOPYB images/start_black_swift.pblb
>   OBJCOPYB images/start_dptechnics_dpt_module.pblb
>   OBJCOPYB images/start_8devices_lima.pblb
>   OBJCOPYB images/start_tplink_mr3020.pblb
>   OBJCOPYB images/start_tplink_wdr4300.pblb
> invalid magic
> barebox/images/Makefile:68: recipe for target
> 'images/start_black_swift.pblb' failed
> make[1]: *** [images/start_black_swift.pblb] Error 1
> make[1]: *** Waiting for unfinished jobs....
> invalid magic

This is because fix_size is called on the .pblb images and fix_size
is written for ARM and doesn't recognize this as a valid image.

What we can do is to call fix_size with -i (which still causes an error
message, but no error. Would have to patch the error message away
aswell).
Another possibility would be to call fix_size only for builds which
support it (ARM).

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox