From: Sascha Hauer <s.hauer@pengutronix.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH v1 3/5] arm: fix no prototype for barebox_arm_reset_vector()
Date: Fri, 4 Jan 2019 08:27:18 +0100 [thread overview]
Message-ID: <20190104072718.czf6qqojjzluua46@pengutronix.de> (raw)
In-Reply-To: <20181231080725.2141-4-sam@ravnborg.org>
On Mon, Dec 31, 2018 at 09:07:23AM +0100, Sam Ravnborg wrote:
> Fix the following warning:
>
> PBLCC arch/arm/boards/at91sam9261ek/pbl-lowlevel_init.o
> arch/arm/boards/at91sam9261ek/lowlevel_init.c:120:26:
> warning: no previous prototype for ‘barebox_arm_reset_vector’ [-Wmissing-prototypes]
>
> Prototype added so it covers machs with their own
> definition and the machs using the arm general variant
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> arch/arm/include/asm/barebox-arm.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/include/asm/barebox-arm.h b/arch/arm/include/asm/barebox-arm.h
> index e065b479e..312685486 100644
> --- a/arch/arm/include/asm/barebox-arm.h
> +++ b/arch/arm/include/asm/barebox-arm.h
> @@ -25,6 +25,7 @@
> #ifndef _BAREBOX_ARM_H_
> #define _BAREBOX_ARM_H_
>
> +#include <init.h>
> #include <linux/sizes.h>
> #include <asm-generic/memory_layout.h>
> #include <linux/kernel.h>
> @@ -58,6 +59,7 @@ void setup_c(void);
> void relocate_to_current_adr(void);
> void relocate_to_adr(unsigned long target);
> void __noreturn barebox_arm_entry(unsigned long membase, unsigned long memsize, void *boarddata);
> +void __naked __bare_init barebox_arm_reset_vector(void);
I had to drop this one as it breaks compilation on some boards. Some
boards need r0 from the ROM so they have:
void __naked __bare_init barebox_arm_reset_vector(uint32_t *data)
We have to harmonize these first. I suggest to use
void __naked __bare_init barebox_arm_reset_vector(uint32_t r0, uint32_t r1, uint32_t r2)
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-01-04 7:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-31 8:07 [PATCH 0/5] Independent collection of patches Sam Ravnborg
2018-12-31 8:07 ` [PATCH v1 1/5] 2d-primitives: fix no previous prototype warning Sam Ravnborg
2018-12-31 8:07 ` [PATCH v1 2/5] images: fix force rebuild of piggy.o Sam Ravnborg
2019-01-03 9:06 ` Sascha Hauer
2018-12-31 8:07 ` [PATCH v1 3/5] arm: fix no prototype for barebox_arm_reset_vector() Sam Ravnborg
2019-01-04 7:27 ` Sascha Hauer [this message]
2019-01-06 20:38 ` Sam Ravnborg
2019-01-07 7:41 ` Sascha Hauer
2018-12-31 8:07 ` [PATCH v1 4/5] at91sam9263ek: fix build of of_init Sam Ravnborg
2018-12-31 8:07 ` [PATCH v1 5/5] video: mtl017: fix driver name variable Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104072718.czf6qqojjzluua46@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox