mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 02/10] serial: clps711x: Switch to SPDX identifier
Date: Fri, 4 Jan 2019 11:46:55 +0100	[thread overview]
Message-ID: <20190104104655.xgwbijdqbay2pq5u@pengutronix.de> (raw)
In-Reply-To: <20181219080403.13737-2-shc_work@mail.ru>

Hi Alexander,

On Wed, Dec 19, 2018 at 11:03:55AM +0300, Alexander Shiyan wrote:
> Adopt the SPDX license identifier headers to ease license compliance
> management.
> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  drivers/serial/serial_clps711x.c | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/serial/serial_clps711x.c b/drivers/serial/serial_clps711x.c
> index 9a9ae24c0..c21ca6510 100644
> --- a/drivers/serial/serial_clps711x.c
> +++ b/drivers/serial/serial_clps711x.c
> @@ -1,13 +1,5 @@
> -/*
> - * Simple CLPS711X serial driver
> - *
> - * (C) Copyright 2012-2014 Alexander Shiyan <shc_work@mail.ru>
> - *
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License as
> - * published by the Free Software Foundation; either version 2 of
> - * the License, or (at your option) any later version.
> - */
> +// SPDX-License-Identifier: GPL-2.0+
> +/* Author: Alexander Shiyan <shc_work@mail.ru> */

Your removed the "Copyright" here and replaced it with "Author", but in
some jurisdictions copyright and authorship are actually different
things, and most automated license compliance tools only look for the
string "Copyright", so your change will probably mean that your name
will not be picked up as copyright. Was this change made deliberately?

Same goes for "[PATCH 06/10] gpio: clps711x: Switch to SPDX identifier".

 - Roland

>  
>  #include <common.h>
>  #include <malloc.h>
> -- 
> 2.13.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-01-04 10:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-19  8:03 [PATCH 01/10] serial: clps711x: Change compatible string Alexander Shiyan
2018-12-19  8:03 ` [PATCH 02/10] serial: clps711x: Switch to SPDX identifier Alexander Shiyan
2019-01-04 10:46   ` Roland Hieber [this message]
2019-01-04 10:48     ` Roland Hieber
2019-01-08 10:45       ` Alexander Shiyan
2018-12-19  8:03 ` [PATCH 03/10] serial: clps711x: Use DIV_ROUND_CLOSEST() for baudrate calculation Alexander Shiyan
2018-12-19  8:03 ` [PATCH 04/10] serial: clps711x: Determine device name from device tree Alexander Shiyan
2018-12-19  8:03 ` [PATCH 05/10] gpio: clps711x: Change compatible string Alexander Shiyan
2018-12-19  8:03 ` [PATCH 06/10] gpio: clps711x: Switch to SPDX identifier Alexander Shiyan
2018-12-19  8:04 ` [PATCH 07/10] gpio: clps711x: Use coredevice_platform_driver() macro Alexander Shiyan
2018-12-19  8:04 ` [PATCH 08/10] clocksource: clps711x: Add devicetree support Alexander Shiyan
2018-12-19  8:04 ` [PATCH 09/10] clocksource: clps711x: Switch to SPDX identifier Alexander Shiyan
2018-12-19  8:04 ` [PATCH 10/10] clocksource: clps711x: Use coredevice_platform_driver() macro Alexander Shiyan
2018-12-20  7:57 ` [PATCH 01/10] serial: clps711x: Change compatible string Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190104104655.xgwbijdqbay2pq5u@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox