From: Sam Ravnborg <sam@ravnborg.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH v1 3/5] arm: fix no prototype for barebox_arm_reset_vector()
Date: Sun, 6 Jan 2019 21:38:11 +0100 [thread overview]
Message-ID: <20190106203811.GA5376@ravnborg.org> (raw)
In-Reply-To: <20190104072718.czf6qqojjzluua46@pengutronix.de>
Hi Sasha.
> > +void __naked __bare_init barebox_arm_reset_vector(void);
>
> I had to drop this one as it breaks compilation on some boards. Some
> boards need r0 from the ROM so they have:
>
> void __naked __bare_init barebox_arm_reset_vector(uint32_t *data)
>
> We have to harmonize these first.
Sorry - I did not test more than a few boards.
> I suggest to use
>
> void __naked __bare_init barebox_arm_reset_vector(uint32_t r0, uint32_t r1, uint32_t r2)
Like the prototype we have for the multi images.
I added this to the TODO list in the doc I just posted.
Sam
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-01-06 20:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-31 8:07 [PATCH 0/5] Independent collection of patches Sam Ravnborg
2018-12-31 8:07 ` [PATCH v1 1/5] 2d-primitives: fix no previous prototype warning Sam Ravnborg
2018-12-31 8:07 ` [PATCH v1 2/5] images: fix force rebuild of piggy.o Sam Ravnborg
2019-01-03 9:06 ` Sascha Hauer
2018-12-31 8:07 ` [PATCH v1 3/5] arm: fix no prototype for barebox_arm_reset_vector() Sam Ravnborg
2019-01-04 7:27 ` Sascha Hauer
2019-01-06 20:38 ` Sam Ravnborg [this message]
2019-01-07 7:41 ` Sascha Hauer
2018-12-31 8:07 ` [PATCH v1 4/5] at91sam9263ek: fix build of of_init Sam Ravnborg
2018-12-31 8:07 ` [PATCH v1 5/5] video: mtl017: fix driver name variable Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190106203811.GA5376@ravnborg.org \
--to=sam@ravnborg.org \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox