mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH v1 1/3] arm: at91: fix clock to mci1 for at91sam9263
Date: Mon, 7 Jan 2019 08:29:07 +0100	[thread overview]
Message-ID: <20190107072907.7eps33ajis3imwh4@pengutronix.de> (raw)
In-Reply-To: <20190102202611.6530-2-sam@ravnborg.org>

On Wed, Jan 02, 2019 at 09:26:09PM +0100, Sam Ravnborg wrote:
> at91_add_device_mci() was missing configuration of PIOA6
> when configuring mci1.
> With this fix we can read data from SD card with at91sam9263ek,
> when built without DT.
> Building without a DT is required when we do a bootstrap build.
> 
> The other at91samxxx_devices was checked - only the 9263 was
> missing the CLK configuration for mci1.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> ---

Applied (this one), thanks

Sascha

>  arch/arm/mach-at91/at91sam9263_devices.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/mach-at91/at91sam9263_devices.c b/arch/arm/mach-at91/at91sam9263_devices.c
> index a67345f05..c7e4962a9 100644
> --- a/arch/arm/mach-at91/at91sam9263_devices.c
> +++ b/arch/arm/mach-at91/at91sam9263_devices.c
> @@ -396,6 +396,9 @@ void at91_add_device_mci(short mmc_id, struct atmel_mci_platform_data *data)
>  	} else {			/* MCI1 */
>  		start = AT91SAM9263_BASE_MCI1;
>  
> +		/* CLK */
> +		at91_set_A_periph(AT91_PIN_PA6, 0);
> +
>  		if (data->slot_b) {
>  			/* CMD */
>  			at91_set_A_periph(AT91_PIN_PA21, 1);
> -- 
> 2.12.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2019-01-07  7:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-02 20:26 [PATCH v1 0/3] bootstrap support for AT91SAM9263-EK Sam Ravnborg
2019-01-02 20:26 ` [PATCH v1 1/3] arm: at91: fix clock to mci1 for at91sam9263 Sam Ravnborg
2019-01-06 20:39   ` Sam Ravnborg
2019-01-07  7:29   ` Sascha Hauer [this message]
2019-01-02 20:26 ` [PATCH v1 2/3] lib: bootstrap: detect SD card before mounting Sam Ravnborg
2019-01-02 23:32   ` Andrey Smirnov
2019-01-03  5:46     ` Sam Ravnborg
2019-01-03 19:53       ` Sam Ravnborg
2019-01-04  7:46         ` Sascha Hauer
2019-01-06 20:39           ` Sam Ravnborg
2019-01-02 20:26 ` [PATCH v1 3/3] at91sam9263ek: add bootstrap support Sam Ravnborg
2019-01-03  8:16   ` Sascha Hauer
2019-01-03 10:58     ` Sam Ravnborg
2019-01-03 21:00       ` Sam Ravnborg
2019-01-04  7:37         ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190107072907.7eps33ajis3imwh4@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox