* [PATCH] memory_display: Fix type of argument passed to %*s
@ 2019-01-09 4:09 Andrey Smirnov
2019-01-09 7:25 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Andrey Smirnov @ 2019-01-09 4:09 UTC (permalink / raw)
To: barebox; +Cc: Andrey Smirnov
On AArch64, pointer arithmetic in (pos - line) resolves into "long
int", whereas "%*s" is expecting regular "int". Add explicit cast to
avoid compiler warnings.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
common/memory_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/memory_display.c b/common/memory_display.c
index cd0eadf88..fbb8bbb6f 100644
--- a/common/memory_display.c
+++ b/common/memory_display.c
@@ -96,7 +96,7 @@ int __pr_memory_display(int level, const void *addr, loff_t offs, unsigned nbyte
offs += size;
}
- pos += sprintf(pos, "%*s", 61 - (pos - line), "");
+ pos += sprintf(pos, "%*s", (int)(61 - (pos - line)), "");
cp = linebuf;
for (i = 0; i < linebytes; i++) {
--
2.20.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] memory_display: Fix type of argument passed to %*s
2019-01-09 4:09 [PATCH] memory_display: Fix type of argument passed to %*s Andrey Smirnov
@ 2019-01-09 7:25 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2019-01-09 7:25 UTC (permalink / raw)
To: Andrey Smirnov; +Cc: barebox
On Tue, Jan 08, 2019 at 08:09:02PM -0800, Andrey Smirnov wrote:
> On AArch64, pointer arithmetic in (pos - line) resolves into "long
> int", whereas "%*s" is expecting regular "int". Add explicit cast to
> avoid compiler warnings.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> common/memory_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/common/memory_display.c b/common/memory_display.c
> index cd0eadf88..fbb8bbb6f 100644
> --- a/common/memory_display.c
> +++ b/common/memory_display.c
> @@ -96,7 +96,7 @@ int __pr_memory_display(int level, const void *addr, loff_t offs, unsigned nbyte
> offs += size;
> }
>
> - pos += sprintf(pos, "%*s", 61 - (pos - line), "");
> + pos += sprintf(pos, "%*s", (int)(61 - (pos - line)), "");
>
> cp = linebuf;
> for (i = 0; i < linebytes; i++) {
> --
> 2.20.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-09 7:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-09 4:09 [PATCH] memory_display: Fix type of argument passed to %*s Andrey Smirnov
2019-01-09 7:25 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox