[PATCH] printk: Pass groupsize to memory_display() in print_hex_dump()

[PATCH] printk: Pass groupsize to memory_display() in print_hex_dump()

[Andrey Smirnov]

Don't hardcode grouping data into 4-byte words in print_hex_dump()
implementation and instead pass 'groupsize' to memory_display(), since
that's what that parameter is for.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 include/printk.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/printk.h b/include/printk.h
index aaad07552..ab2c64cf3 100644
--- a/include/printk.h
+++ b/include/printk.h
@@ -119,7 +119,7 @@ static inline void print_hex_dump(const char *level, const char *prefix_str,
 		int prefix_type, int rowsize, int groupsize,
 		const void *buf, size_t len, bool ascii)
 {
-	memory_display(buf, 0, len, 4, 0);
+	memory_display(buf, 0, len, groupsize, 0);
 }
 
 struct log_entry {
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] printk: Pass groupsize to memory_display() in print_hex_dump()

[Sascha Hauer]

On Tue, Jan 08, 2019 at 08:09:33PM -0800, Andrey Smirnov wrote:
> Don't hardcode grouping data into 4-byte words in print_hex_dump()
> implementation and instead pass 'groupsize' to memory_display(), since
> that's what that parameter is for.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  include/printk.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/include/printk.h b/include/printk.h
> index aaad07552..ab2c64cf3 100644
> --- a/include/printk.h
> +++ b/include/printk.h
> @@ -119,7 +119,7 @@ static inline void print_hex_dump(const char *level, const char *prefix_str,
>  		int prefix_type, int rowsize, int groupsize,
>  		const void *buf, size_t len, bool ascii)
>  {
> -	memory_display(buf, 0, len, 4, 0);
> +	memory_display(buf, 0, len, groupsize, 0);
>  }
>  
>  struct log_entry {
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox