From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH 10/21] soc: imx: gpcv2: fix regulator deferred probe
Date: Tue, 8 Jan 2019 23:11:59 -0800 [thread overview]
Message-ID: <20190109071210.18896-11-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20190109071210.18896-1-andrew.smirnov@gmail.com>
Port of a Linux commit 9e01e2d56db23485a75864b6aeee8e443f024ddb
If a regulator requests a deferred probe, the power domain gets
initialized twice. This leads to a list double add (without
list debugging the kernel hangs due to the double add later):
WARNING: CPU: 0 PID: 19 at lib/list_debug.c:31 __list_add_valid+0xbc/0xc4
list_add double add: new=c1229754, prev=c12383b4, next=c1229754.
Initialize the power domain after we get the regulator. Also do
not print an error in case the regulator defers probing.
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Fixes: 03aa12629fc4 ("soc: imx: Add GPCv2 power gating driver")
Signed-off-by: Stefan Agner <stefan@agner.ch>
Acked-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Tested-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
drivers/soc/imx/gpcv2.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
index 918a35462..f16598e97 100644
--- a/drivers/soc/imx/gpcv2.c
+++ b/drivers/soc/imx/gpcv2.c
@@ -200,16 +200,11 @@ static int imx7_pgc_domain_probe(struct device_d *dev)
domain->dev = dev;
- ret = pm_genpd_init(&domain->genpd, NULL, true);
- if (ret) {
- dev_err(domain->dev, "Failed to init power domain\n");
- return ret;
- }
-
domain->regulator = regulator_get(domain->dev, "power");
if (IS_ERR(domain->regulator)) {
if (PTR_ERR(domain->regulator) != -ENODEV) {
- dev_err(domain->dev, "Failed to get domain's regulator\n");
+ if (PTR_ERR(domain->regulator) != -EPROBE_DEFER)
+ dev_err(domain->dev, "Failed to get domain's regulator\n");
return PTR_ERR(domain->regulator);
}
} else {
@@ -217,6 +212,12 @@ static int imx7_pgc_domain_probe(struct device_d *dev)
domain->voltage, domain->voltage);
}
+ ret = pm_genpd_init(&domain->genpd, NULL, true);
+ if (ret) {
+ dev_err(domain->dev, "Failed to init power domain\n");
+ return ret;
+ }
+
ret = of_genpd_add_provider_simple(domain->dev->device_node,
&domain->genpd);
if (ret) {
--
2.20.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-01-09 7:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 7:11 [PATCH 00/21] PCIe support for i.MX7 Andrey Smirnov
2019-01-09 7:11 ` [PATCH 01/21] regulator: Convert drivers to use struct regulator_desc Andrey Smirnov
2019-01-09 7:11 ` [PATCH 02/21] regulator: Port basic regmap regulator functions Andrey Smirnov
2019-01-09 7:11 ` [PATCH 03/21] regulator: Add support for setting regulator's voltage Andrey Smirnov
2019-01-09 7:11 ` [PATCH 04/21] base: driver: Drop redundant list_empty() check Andrey Smirnov
2019-01-09 7:11 ` [PATCH 05/21] base: Port driver_deferred_probe_check_state() from Linux Andrey Smirnov
2019-01-09 7:11 ` [PATCH 06/21] regulator: Add primitive support for deferred probe Andrey Smirnov
2019-01-09 7:11 ` [PATCH 07/21] regulator: Port ANATOP driver from Linux Andrey Smirnov
2019-01-09 7:11 ` [PATCH 08/21] drivers: base: Port power management code " Andrey Smirnov
2019-01-09 7:11 ` [PATCH 09/21] soc: imx: Add GPCv2 power gating driver Andrey Smirnov
2019-01-09 7:11 ` Andrey Smirnov [this message]
2019-01-10 7:37 ` [PATCH 10/21] soc: imx: gpcv2: fix regulator deferred probe Sascha Hauer
2019-01-10 19:20 ` Andrey Smirnov
2019-01-09 7:12 ` [PATCH 11/21] soc: imx: gpcv2: correct PGC offset Andrey Smirnov
2019-01-09 7:12 ` [PATCH 12/21] reset: Add i.MX7 SRC reset driver Andrey Smirnov
2019-01-09 7:12 ` [PATCH 13/21] reset: imx7: Fix always writing bits as 0 Andrey Smirnov
2019-01-10 7:38 ` Sascha Hauer
2019-01-09 7:12 ` [PATCH 14/21] reset: Mark local functions as static Andrey Smirnov
2019-01-09 7:12 ` [PATCH 15/21] PCI: imx6: Add code to support i.MX7D Andrey Smirnov
2019-01-09 7:12 ` [PATCH 16/21] PCI: imx6: Allow probe deferral by reset GPIO Andrey Smirnov
2019-01-10 8:05 ` Sascha Hauer
2019-01-12 4:24 ` Andrey Smirnov
2019-01-09 7:12 ` [PATCH 17/21] PCI: imx6: Do not wait for speed change on i.MX7 Andrey Smirnov
2019-01-09 7:12 ` [PATCH 18/21] PCI: imx6: Do not switch speed if Gen2 is disabled Andrey Smirnov
2019-01-09 7:12 ` [PATCH 19/21] PCI: imx6: Fix spelling mistake: "contol" -> "control" Andrey Smirnov
2019-01-09 7:12 ` [PATCH 20/21] PCI: imx6: Drop unnecessary root_bus_nr setting Andrey Smirnov
2019-01-09 7:12 ` [PATCH 21/21] PCI: imx6: Port imx6_pcie_ltssm_enable() Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109071210.18896-11-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox