[PATCH] memory_display: Fix type of argument passed to %*s

[PATCH] memory_display: Fix type of argument passed to %*s

[Andrey Smirnov]

On AArch64, pointer arithmetic in (pos - line) resolves into "long
int", whereas "%*s" is expecting regular "int". Add explicit cast to
avoid compiler warnings.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 common/memory_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/memory_display.c b/common/memory_display.c
index cd0eadf88..fbb8bbb6f 100644
--- a/common/memory_display.c
+++ b/common/memory_display.c
@@ -96,7 +96,7 @@ int __pr_memory_display(int level, const void *addr, loff_t offs, unsigned nbyte
 			offs += size;
 		}
 
-		pos += sprintf(pos, "%*s", 61 - (pos - line), "");
+		pos += sprintf(pos, "%*s", (int)(61 - (pos - line)), "");
 
 		cp = linebuf;
 		for (i = 0; i < linebytes; i++) {
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] memory_display: Fix type of argument passed to %*s

[Sascha Hauer]

On Tue, Jan 08, 2019 at 08:09:02PM -0800, Andrey Smirnov wrote:
> On AArch64, pointer arithmetic in (pos - line) resolves into "long
> int", whereas "%*s" is expecting regular "int". Add explicit cast to
> avoid compiler warnings.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  common/memory_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/common/memory_display.c b/common/memory_display.c
> index cd0eadf88..fbb8bbb6f 100644
> --- a/common/memory_display.c
> +++ b/common/memory_display.c
> @@ -96,7 +96,7 @@ int __pr_memory_display(int level, const void *addr, loff_t offs, unsigned nbyte
>  			offs += size;
>  		}
>  
> -		pos += sprintf(pos, "%*s", 61 - (pos - line), "");
> +		pos += sprintf(pos, "%*s", (int)(61 - (pos - line)), "");
>  
>  		cp = linebuf;
>  		for (i = 0; i < linebytes; i++) {
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox