From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] printk: Pass groupsize to memory_display() in print_hex_dump()
Date: Wed, 9 Jan 2019 08:26:33 +0100 [thread overview]
Message-ID: <20190109072633.ud37c42awunyfhxj@pengutronix.de> (raw)
In-Reply-To: <20190109040933.19554-1-andrew.smirnov@gmail.com>
On Tue, Jan 08, 2019 at 08:09:33PM -0800, Andrey Smirnov wrote:
> Don't hardcode grouping data into 4-byte words in print_hex_dump()
> implementation and instead pass 'groupsize' to memory_display(), since
> that's what that parameter is for.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> include/printk.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/include/printk.h b/include/printk.h
> index aaad07552..ab2c64cf3 100644
> --- a/include/printk.h
> +++ b/include/printk.h
> @@ -119,7 +119,7 @@ static inline void print_hex_dump(const char *level, const char *prefix_str,
> int prefix_type, int rowsize, int groupsize,
> const void *buf, size_t len, bool ascii)
> {
> - memory_display(buf, 0, len, 4, 0);
> + memory_display(buf, 0, len, groupsize, 0);
> }
>
> struct log_entry {
> --
> 2.20.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-01-09 7:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 4:09 Andrey Smirnov
2019-01-09 7:26 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109072633.ud37c42awunyfhxj@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox