From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1ghUtx-0005si-69 for barebox@lists.infradead.org; Thu, 10 Jan 2019 07:37:19 +0000 Date: Thu, 10 Jan 2019 08:37:14 +0100 From: Sascha Hauer Message-ID: <20190110073714.effcrzo3b32hyydc@pengutronix.de> References: <20190109071210.18896-1-andrew.smirnov@gmail.com> <20190109071210.18896-11-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190109071210.18896-11-andrew.smirnov@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 10/21] soc: imx: gpcv2: fix regulator deferred probe To: Andrey Smirnov Cc: barebox@lists.infradead.org On Tue, Jan 08, 2019 at 11:11:59PM -0800, Andrey Smirnov wrote: > Port of a Linux commit 9e01e2d56db23485a75864b6aeee8e443f024ddb > > If a regulator requests a deferred probe, the power domain gets > initialized twice. This leads to a list double add (without > list debugging the kernel hangs due to the double add later): > > WARNING: CPU: 0 PID: 19 at lib/list_debug.c:31 __list_add_valid+0xbc/0xc4 > list_add double add: new=c1229754, prev=c12383b4, next=c1229754. > > Initialize the power domain after we get the regulator. Also do > not print an error in case the regulator defers probing. > > Cc: Fabio Estevam > Cc: Andrey Smirnov > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Fixes: 03aa12629fc4 ("soc: imx: Add GPCv2 power gating driver") > Signed-off-by: Stefan Agner > Acked-by: Andrey Smirnov > Tested-by: Andrey Smirnov > Signed-off-by: Shawn Guo > > Signed-off-by: Andrey Smirnov > --- > drivers/soc/imx/gpcv2.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) This file has been added in the last patch. Please squash this patch and the next one into it. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox