From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH 5/6] commands: digest: Use MAX_LFS_FILESIZE instead of ~0
Date: Sat, 12 Jan 2019 00:24:55 -0800 [thread overview]
Message-ID: <20190112082456.7441-6-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20190112082456.7441-1-andrew.smirnov@gmail.com>
Loff_t is a signed type, so ~0 is a negative number. While it works OK
due to clamping/conversion to ulong when passed to
digest_file_window(), it is better not to rely on that fact and use an
appropriate constant.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
commands/digest.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/commands/digest.c b/commands/digest.c
index 0edbbec32c..99b27dcc25 100644
--- a/commands/digest.c
+++ b/commands/digest.c
@@ -6,6 +6,7 @@
#include <common.h>
#include <command.h>
+#include <linux/pagemap.h>
#include <fs.h>
#include <fcntl.h>
#include <errno.h>
@@ -35,7 +36,7 @@ int __do_digest(struct digest *d, unsigned char *sig,
while (*argv) {
char *filename = "/dev/mem";
- loff_t start = 0, size = ~0;
+ loff_t start = 0, size = MAX_LFS_FILESIZE;
int show_area = 1;
/* arguments are either file, file+area or area */
--
2.20.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-01-12 8:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 8:24 [PATCH 0/6] Support for digesting large files (> 4 GiB) Andrey Smirnov
2019-01-12 8:24 ` [PATCH 1/6] treewide: Introduce MAP_FAILED and replace ad-hoc constants with it Andrey Smirnov
2019-01-12 8:24 ` [PATCH 2/6] crypto: digest: Remove unused variable Andrey Smirnov
2019-01-12 8:24 ` [PATCH 3/6] crypto: digest: Replace 4096 with PAGE_SIZE Andrey Smirnov
2019-01-12 8:24 ` [PATCH 4/6] crypto: digest: Split memory vs. file code into separate functions Andrey Smirnov
2019-01-12 11:18 ` Sam Ravnborg
2019-01-12 20:34 ` Andrey Smirnov
2019-01-12 8:24 ` Andrey Smirnov [this message]
2019-01-12 8:24 ` [PATCH 6/6] crypto: digest: Change the signature of digest_file_window() Andrey Smirnov
2019-01-12 11:19 ` [PATCH 0/6] Support for digesting large files (> 4 GiB) Sam Ravnborg
2019-01-16 7:34 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190112082456.7441-6-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox