mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 0/6] Support for digesting large files (> 4 GiB)
Date: Sat, 12 Jan 2019 12:19:51 +0100	[thread overview]
Message-ID: <20190112111951.GH14273@ravnborg.org> (raw)
In-Reply-To: <20190112082456.7441-1-andrew.smirnov@gmail.com>

Hi Andrey.


> If "crypto: digest: Split memory vs. file code
> into separate functions" is too controversial it can be dropped.
An improvement to readability if you ask me.

One nit, otherwise series looks good.

	Sam

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2019-01-12 11:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-12  8:24 Andrey Smirnov
2019-01-12  8:24 ` [PATCH 1/6] treewide: Introduce MAP_FAILED and replace ad-hoc constants with it Andrey Smirnov
2019-01-12  8:24 ` [PATCH 2/6] crypto: digest: Remove unused variable Andrey Smirnov
2019-01-12  8:24 ` [PATCH 3/6] crypto: digest: Replace 4096 with PAGE_SIZE Andrey Smirnov
2019-01-12  8:24 ` [PATCH 4/6] crypto: digest: Split memory vs. file code into separate functions Andrey Smirnov
2019-01-12 11:18   ` Sam Ravnborg
2019-01-12 20:34     ` Andrey Smirnov
2019-01-12  8:24 ` [PATCH 5/6] commands: digest: Use MAX_LFS_FILESIZE instead of ~0 Andrey Smirnov
2019-01-12  8:24 ` [PATCH 6/6] crypto: digest: Change the signature of digest_file_window() Andrey Smirnov
2019-01-12 11:19 ` Sam Ravnborg [this message]
2019-01-16  7:34 ` [PATCH 0/6] Support for digesting large files (> 4 GiB) Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190112111951.GH14273@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox