mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH v3 15/16] PCI: Convert ->res_start() to return resource_size_t
Date: Sun, 13 Jan 2019 22:17:08 -0800	[thread overview]
Message-ID: <20190114061709.13948-16-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20190114061709.13948-1-andrew.smirnov@gmail.com>

On 64-bit machines int doesn't cover full address space, so convert
.res_start to both accept resource_size_t as a parameter and return it
as result.

Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 arch/mips/mach-malta/pci.c | 3 ++-
 drivers/pci/pci-mvebu.c    | 6 ++++--
 include/linux/pci.h        | 2 +-
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/arch/mips/mach-malta/pci.c b/arch/mips/mach-malta/pci.c
index 47c0e228a7..4561123d22 100644
--- a/arch/mips/mach-malta/pci.c
+++ b/arch/mips/mach-malta/pci.c
@@ -131,7 +131,8 @@ static int gt64xxx_pci0_pcibios_write(struct pci_bus *bus, unsigned int devfn,
 }
 
 /* function returns memory address for begin of pci resource */
-static int gt64xxx_res_start(struct pci_bus *bus, resource_size_t res_addr)
+static resource_size_t gt64xxx_res_start(struct pci_bus *bus,
+					 resource_size_t res_addr)
 {
 	return KSEG0ADDR(res_addr);
 }
diff --git a/drivers/pci/pci-mvebu.c b/drivers/pci/pci-mvebu.c
index 1c20f91544..c17ef3898b 100644
--- a/drivers/pci/pci-mvebu.c
+++ b/drivers/pci/pci-mvebu.c
@@ -145,11 +145,13 @@ static int mvebu_pcie_indirect_wr_conf(struct pci_bus *bus,
 	return PCIBIOS_SUCCESSFUL;
 }
 
-static int mvebu_pcie_res_start(struct pci_bus *bus, resource_size_t res_addr)
+static resource_size_t mvebu_pcie_res_start(struct pci_bus *bus,
+					    resource_size_t res_addr)
 {
 	struct mvebu_pcie *pcie = to_pcie(bus->host);
 
-	return (int)pcie->membase + (res_addr & (resource_size(&pcie->mem)-1));
+	return (resource_size_t)pcie->membase +
+		(res_addr & (resource_size(&pcie->mem) - 1));
 }
 
 static struct pci_ops mvebu_pcie_indirect_ops = {
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 2c7acbdda9..c00a866a48 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -143,7 +143,7 @@ struct pci_ops {
 	int (*write)(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val);
 
 	/* return memory address for pci resource */
-	int (*res_start)(struct pci_bus *bus, resource_size_t res_addr);
+	resource_size_t (*res_start)(struct pci_bus *bus, resource_size_t res_addr);
 };
 
 extern struct pci_ops *pci_ops;
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2019-01-14  6:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14  6:16 [PATCH v3 00/16] PCI improvements Andrey Smirnov
2019-01-14  6:16 ` [PATCH v3 01/16] PCI: Switch to using %pa to print memory addresses Andrey Smirnov
2019-01-14  6:16 ` [PATCH v3 02/16] PCI: Replace magic number in setup_device() Andrey Smirnov
2019-01-14  6:16 ` [PATCH v3 03/16] PCI: Remove superfluous parens " Andrey Smirnov
2019-01-14  6:16 ` [PATCH v3 04/16] PCI: Simplify resource setup code " Andrey Smirnov
2019-01-14  6:16 ` [PATCH v3 05/16] PCI: Store and reuse BAR offsets Andrey Smirnov
2019-01-14  6:16 ` [PATCH v3 06/16] PCI: Remove unused variables/code Andrey Smirnov
2019-01-14  6:17 ` [PATCH v3 07/16] PCI: Make pci_scan_bus static Andrey Smirnov
2019-01-14  6:17 ` [PATCH v3 08/16] PCI: Drop "slots" from struct pci_bus Andrey Smirnov
2019-01-14  6:17 ` [PATCH v3 09/16] PCI: Drop "resources" " Andrey Smirnov
2019-01-14  6:17 ` [PATCH v3 10/16] PCI: Drop "name" " Andrey Smirnov
2019-01-14  6:17 ` [PATCH v3 11/16] PCI: Drop "ops" " Andrey Smirnov
2019-01-14  6:17 ` [PATCH v3 12/16] PCI: Drop "rom_address" from struct pci_dev Andrey Smirnov
2019-01-14  6:17 ` [PATCH v3 13/16] PCI: Simplify alloc_pci_dev() Andrey Smirnov
2019-01-14  6:17 ` [PATCH v3 14/16] PCI: Assume 1:1 mapping if .res_start callback is NULL Andrey Smirnov
2019-01-14  6:17 ` Andrey Smirnov [this message]
2019-01-14  6:17 ` [PATCH v3 16/16] PCI: Consify pci_ops in struct pci_controller Andrey Smirnov
2019-01-16  7:36 ` [PATCH v3 00/16] PCI improvements Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190114061709.13948-16-andrew.smirnov@gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox