From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH v3 01/16] PCI: Switch to using %pa to print memory addresses
Date: Sun, 13 Jan 2019 22:16:54 -0800 [thread overview]
Message-ID: <20190114061709.13948-2-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20190114061709.13948-1-andrew.smirnov@gmail.com>
Switch to using %pa to print memory addresses in order to be able to
support both 64 and 32 bit builds.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
drivers/pci/pci.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 7abc7a3439..1f9d360d79 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -195,7 +195,7 @@ static void setup_device(struct pci_dev *dev, int max_bar)
return;
}
last_io = ALIGN(last_io, size);
- pr_debug("pbar%d: allocated at 0x%08x\n", bar, last_io);
+ pr_debug("pbar%d: allocated at %pa\n", bar, &last_io);
pci_write_config_dword(dev, PCI_BASE_ADDRESS_0 + bar * 4, last_io);
dev->resource[bar].flags = IORESOURCE_IO;
last_addr = last_io;
@@ -215,7 +215,7 @@ static void setup_device(struct pci_dev *dev, int max_bar)
return;
}
last_mem_pref = ALIGN(last_mem_pref, size);
- pr_debug("pbar%d: allocated at 0x%08x\n", bar, last_mem_pref);
+ pr_debug("pbar%d: allocated at %pa\n", bar, &last_mem_pref);
pci_write_config_dword(dev, PCI_BASE_ADDRESS_0 + bar * 4, last_mem_pref);
dev->resource[bar].flags = IORESOURCE_MEM |
IORESOURCE_PREFETCH;
@@ -235,7 +235,7 @@ static void setup_device(struct pci_dev *dev, int max_bar)
return;
}
last_mem = ALIGN(last_mem, size);
- pr_debug("pbar%d: allocated at 0x%08x\n", bar, last_mem);
+ pr_debug("pbar%d: allocated at %pa\n", bar, &last_mem);
pci_write_config_dword(dev, PCI_BASE_ADDRESS_0 + bar * 4, last_mem);
dev->resource[bar].flags = IORESOURCE_MEM;
last_addr = last_mem;
@@ -311,21 +311,21 @@ static void postscan_setup_bridge(struct pci_dev *dev)
if (last_mem) {
last_mem = ALIGN(last_mem, SZ_1M);
- pr_debug("bridge NP limit at 0x%08x\n", last_mem);
+ pr_debug("bridge NP limit at %pa\n", &last_mem);
pci_write_config_word(dev, PCI_MEMORY_LIMIT,
((last_mem - 1) & 0xfff00000) >> 16);
}
if (last_mem_pref) {
last_mem_pref = ALIGN(last_mem_pref, SZ_1M);
- pr_debug("bridge P limit at 0x%08x\n", last_mem_pref);
+ pr_debug("bridge P limit at %pa\n", &last_mem_pref);
pci_write_config_word(dev, PCI_PREF_MEMORY_LIMIT,
((last_mem_pref - 1) & 0xfff00000) >> 16);
}
if (last_io) {
last_io = ALIGN(last_io, SZ_4K);
- pr_debug("bridge IO limit at 0x%08x\n", last_io);
+ pr_debug("bridge IO limit at %pa\n", &last_io);
pci_write_config_byte(dev, PCI_IO_LIMIT,
((last_io - 1) & 0x0000f000) >> 8);
pci_write_config_word(dev, PCI_IO_LIMIT_UPPER16,
@@ -366,8 +366,8 @@ unsigned int pci_scan_bus(struct pci_bus *bus)
unsigned char cmd, tmp, hdr_type, is_multi = 0;
pr_debug("pci_scan_bus for bus %d\n", bus->number);
- pr_debug(" last_io = 0x%08x, last_mem = 0x%08x, last_mem_pref = 0x%08x\n",
- last_io, last_mem, last_mem_pref);
+ pr_debug(" last_io = %pa, last_mem = %pa, last_mem_pref = %pa\n",
+ &last_io, &last_mem, &last_mem_pref);
max = bus->secondary;
--
2.20.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-01-14 6:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 6:16 [PATCH v3 00/16] PCI improvements Andrey Smirnov
2019-01-14 6:16 ` Andrey Smirnov [this message]
2019-01-14 6:16 ` [PATCH v3 02/16] PCI: Replace magic number in setup_device() Andrey Smirnov
2019-01-14 6:16 ` [PATCH v3 03/16] PCI: Remove superfluous parens " Andrey Smirnov
2019-01-14 6:16 ` [PATCH v3 04/16] PCI: Simplify resource setup code " Andrey Smirnov
2019-01-14 6:16 ` [PATCH v3 05/16] PCI: Store and reuse BAR offsets Andrey Smirnov
2019-01-14 6:16 ` [PATCH v3 06/16] PCI: Remove unused variables/code Andrey Smirnov
2019-01-14 6:17 ` [PATCH v3 07/16] PCI: Make pci_scan_bus static Andrey Smirnov
2019-01-14 6:17 ` [PATCH v3 08/16] PCI: Drop "slots" from struct pci_bus Andrey Smirnov
2019-01-14 6:17 ` [PATCH v3 09/16] PCI: Drop "resources" " Andrey Smirnov
2019-01-14 6:17 ` [PATCH v3 10/16] PCI: Drop "name" " Andrey Smirnov
2019-01-14 6:17 ` [PATCH v3 11/16] PCI: Drop "ops" " Andrey Smirnov
2019-01-14 6:17 ` [PATCH v3 12/16] PCI: Drop "rom_address" from struct pci_dev Andrey Smirnov
2019-01-14 6:17 ` [PATCH v3 13/16] PCI: Simplify alloc_pci_dev() Andrey Smirnov
2019-01-14 6:17 ` [PATCH v3 14/16] PCI: Assume 1:1 mapping if .res_start callback is NULL Andrey Smirnov
2019-01-14 6:17 ` [PATCH v3 15/16] PCI: Convert ->res_start() to return resource_size_t Andrey Smirnov
2019-01-14 6:17 ` [PATCH v3 16/16] PCI: Consify pci_ops in struct pci_controller Andrey Smirnov
2019-01-16 7:36 ` [PATCH v3 00/16] PCI improvements Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114061709.13948-2-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox