Re: [PATCH v6 0/9] Raspberry Pi miniuart support

[Roland Hieber <rhi@pengutronix.de>]

On Tue, Jan 15, 2019 at 01:51:32PM +0100, Rouven Czerwinski wrote:
> Looks like RPI W is wired the same way as RPI3.
> I think for the RPI Zero W you'll need two additional lines:
> 
> #define BCM2835_MINIUART_BASE 0x20215040
> 
> and
> clkdev_add_physbase(clk, BCM2835_MINIUART_BASE, NULL);
> in rpi_console_clock_init.
> 
> These should enable the clkdev for the uart and should barebox allow to
> probe the miniuart on RPI Zero W.

Apparently this is not enough, same behaviour. I also tried adding a
separate device tree and image for RPi Zero and have the chosen node
point to uart1, like on the RPi 3, but that didn't help either.

Additionally it turned out that RPi Zero is not even booting with
previous releases - DistroKit had a patch recently to enable the debug
uart for the RPi Zero in config.txt, based on barebox 2018.03.0, but I
couldn't even get this constellation to boot to barebox. So I think
further investigation is needed, and my complaints are out of focus for
this patch series :)

 - Roland

> 
> Don't forget to remove the uart_2ndstage=1, this line also switches
> PL011 and the miniuart.
> 
> - Emantor
> 
> On Tue, 2019-01-15 at 12:01 +0100, Roland Hieber wrote:
> > Hi,
> > 
> > just a short notice, I tested in on my small board farm, RPi 1 and
> > RPi 3
> > boot okay, but RPi Zero W doesn't show a barebox prompt. When
> > enabling
> > uart_2ndstage=1 in config.txt, the firmware hangs after
> > 
> >     MESS:00:00:02.864061:0: uart: Baud rate change done...
> >     MESS:00:00:02.867490:0: uart: Baud rate
> > 
> > The docs don't claim that we officially to support that board
> > though... :P
> > 
> >  - Roland
> > 
> > On Tue, Jan 15, 2019 at 06:44:00AM +0100, Rouven Czerwinski wrote:
> > > This patch series adds support for the raspberry pi miniuart (also
> > > called
> > > aux-uart) to barebox.
> > > With this series the miniuart overlay is no longer necessary to
> > > start barebox on
> > > Raspberry Pi 3.
> > > 
> > > v6:
> > > - Remove leftover val and missing fixup of the AUX Clock defines
> > > 
> > > v5:
> > > - Add defines for register and base values
> > >   from Sascha Hauer and Roland Hieber
> > > 
> > > v4:
> > > - Fix indentation for compatible
> > > - Fix __maybe_unused annnotation for rpi_drvdata missed in v3
> > >   from Sascha Hauer
> > > 
> > > v3:
> > > - Fix Indentation
> > >   from Oleksij Rempel and Sascha Hauer
> > > 
> > > v2:
> > > - Move console clock initialization into board core
> > > - Retrieve the core clock frequency for the miniuart from the
> > > firmware
> > > - Double the clock frequency in the ns16550 rpi init function
> > > instead of
> > >   during initialization
> > >   from Lucas Stach
> > > 
> > > Rouven Czerwinski (9):
> > >   ARM: rpi: fix typo in rpi-common.c
> > >   ARM: rpi: move clks into board specific rpi-common
> > >   ARM: rpi: retrieve miniuart clock from firmware
> > >   serial_ns16550: handle default reg-io-width
> > >   serial_ns16550: add raspberry pi compatible and init
> > >   ARM: rpi: add NS16550 support
> > >   ARM: rpi: choose miniuart as stdout
> > >   doc: bcm283x: remove miniuart overlay instruction
> > >   ARM: rpi: use defines for uart bases
> > > 
> > >  Documentation/boards/bcm2835.rst          |  1 +-
> > >  arch/arm/boards/raspberry-pi/rpi-common.c | 34 ++++++++++-
> > >  arch/arm/configs/rpi_defconfig            |  1 +-
> > >  arch/arm/dts/bcm2837-rpi-3.dts            |  7 +--
> > >  arch/arm/mach-bcm283x/core.c              | 19 +------
> > >  drivers/serial/serial_ns16550.c           | 74 ++++++++++++++++---
> > > -----
> > >  6 files changed, 85 insertions(+), 51 deletions(-)
> > > 
> > > base-commit: 0b5361a328632e64c14a54306119093a0c7fecdf
> > > -- 
> > > git-series 0.9.1
> > > 
> > > _______________________________________________
> > > barebox mailing list
> > > barebox@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/barebox
> > > 
> > 
> > 
> 

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox