From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] block: Alias block_op_close() to block_op_flush()
Date: Wed, 16 Jan 2019 08:29:08 +0100 [thread overview]
Message-ID: <20190116072908.ykjsg2kjbpdxxtna@pengutronix.de> (raw)
In-Reply-To: <20190112055815.12180-1-andrew.smirnov@gmail.com>
On Fri, Jan 11, 2019 at 09:58:14PM -0800, Andrey Smirnov wrote:
> The two functions are identical, so there's no need to keep two copies
> of the same code around. Alias block_op_close() to block_op_flush()
> and drop standalone definition for the former.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> common/block.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/common/block.c b/common/block.c
> index 8d0de42d90..549df71a9d 100644
> --- a/common/block.c
> +++ b/common/block.c
> @@ -329,13 +329,6 @@ static ssize_t block_op_write(struct cdev *cdev, const void *buf, size_t count,
> }
> #endif
>
> -static int block_op_close(struct cdev *cdev)
> -{
> - struct block_device *blk = cdev->priv;
> -
> - return writebuffer_flush(blk);
> -}
> -
> static int block_op_flush(struct cdev *cdev)
> {
> struct block_device *blk = cdev->priv;
> @@ -343,6 +336,8 @@ static int block_op_flush(struct cdev *cdev)
> return writebuffer_flush(blk);
> }
>
> +static int block_op_close(struct cdev *cdev) __alias(block_op_flush);
> +
> static struct cdev_operations block_ops = {
> .read = block_op_read,
> #ifdef CONFIG_BLOCK_WRITE
> --
> 2.20.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-01-16 7:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 5:58 Andrey Smirnov
2019-01-12 5:58 ` [PATCH 2/2] block: Replace debug() with dev_dbg() Andrey Smirnov
2019-01-16 7:29 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116072908.ykjsg2kjbpdxxtna@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox