mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/3] crypto: digest: Return -errno if open() fails
Date: Thu, 17 Jan 2019 06:55:58 +0100	[thread overview]
Message-ID: <20190117055558.GA28203@ravnborg.org> (raw)
In-Reply-To: <20190117044506.20628-1-andrew.smirnov@gmail.com>

On Wed, Jan 16, 2019 at 08:45:04PM -0800, Andrey Smirnov wrote:
> Strictly speaking, open() doesn't return a detailed error code as its
> return value and it can and should be obtained via 'errno'.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  crypto/digest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/crypto/digest.c b/crypto/digest.c
> index 9b7b73019..493e56902 100644
> --- a/crypto/digest.c
> +++ b/crypto/digest.c
> @@ -289,7 +289,7 @@ int digest_file_window(struct digest *d, const char *filename,
>  	fd = open(filename, O_RDONLY);
>  	if (fd < 0) {
>  		perror(filename);
> -		return fd;
> +		return -errno;
>  	}
>  
>  	buf = memmap(fd, PROT_READ);

Looks fine,
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2019-01-17  5:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17  4:45 Andrey Smirnov
2019-01-17  4:45 ` [PATCH 2/3] crypto: digest: Return -errno if lseek() fails Andrey Smirnov
2019-01-17  5:56   ` Sam Ravnborg
2019-01-17  4:45 ` [PATCH 3/3] crypto: digest: Return -errno if stat() fails Andrey Smirnov
2019-01-17  5:56   ` Sam Ravnborg
2019-01-17  5:55 ` Sam Ravnborg [this message]
2019-01-17  8:42 ` [PATCH 1/3] crypto: digest: Return -errno if open() fails Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190117055558.GA28203@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox