From: Sam Ravnborg <sam@ravnborg.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/3] crypto: digest: Return -errno if lseek() fails
Date: Thu, 17 Jan 2019 06:56:16 +0100 [thread overview]
Message-ID: <20190117055616.GB28203@ravnborg.org> (raw)
In-Reply-To: <20190117044506.20628-2-andrew.smirnov@gmail.com>
On Wed, Jan 16, 2019 at 08:45:05PM -0800, Andrey Smirnov wrote:
> Strictly speaking, lseek() doesn't return a detailed error code as its
> return value and it can and should be obtained via 'errno'. In this
> case this change also allows us to avoid potential problems from
> downconverting 'loff_t' to 'int'.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> crypto/digest.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/crypto/digest.c b/crypto/digest.c
> index 493e56902..230db26e8 100644
> --- a/crypto/digest.c
> +++ b/crypto/digest.c
> @@ -226,9 +226,9 @@ static int digest_update_from_fd(struct digest *d, int fd,
> unsigned char *buf = xmalloc(PAGE_SIZE);
> int ret = 0;
>
> - ret = lseek(fd, start, SEEK_SET);
> - if (ret == -1) {
> + if (lseek(fd, start, SEEK_SET) != start) {
> perror("lseek");
> + ret = -errno;
> goto out_free;
> }
Looks fine,
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-01-17 5:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 4:45 [PATCH 1/3] crypto: digest: Return -errno if open() fails Andrey Smirnov
2019-01-17 4:45 ` [PATCH 2/3] crypto: digest: Return -errno if lseek() fails Andrey Smirnov
2019-01-17 5:56 ` Sam Ravnborg [this message]
2019-01-17 4:45 ` [PATCH 3/3] crypto: digest: Return -errno if stat() fails Andrey Smirnov
2019-01-17 5:56 ` Sam Ravnborg
2019-01-17 5:55 ` [PATCH 1/3] crypto: digest: Return -errno if open() fails Sam Ravnborg
2019-01-17 8:42 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117055616.GB28203@ravnborg.org \
--to=sam@ravnborg.org \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox