[PATCH] images: check for use of obsolete pblx-*

[PATCH] images: check for use of obsolete pblx-*

[Ahmad Fatoum]

pblx-* has been removed in 5a1a5ed253 ("ARM: images: use piggydata")
and using it (e.g. because a patchset was rebased) results in a non-obvious:

	make[1]: *** No rule to make target 'images/*.pblx.*', \
	needed by 'images/barebox-*.img'.  Stop.

Avoid this by explicitly failing with an error message whenever pblx-y
or pblx- has been defined.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 images/Makefile | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/images/Makefile b/images/Makefile
index c4b2a483fbd1..c3ec498865da 100644
--- a/images/Makefile
+++ b/images/Makefile
@@ -105,6 +105,10 @@ include $(srctree)/images/Makefile.tegra
 include $(srctree)/images/Makefile.vexpress
 include $(srctree)/images/Makefile.at91
 
+ifneq ($(pblx-y)$(pblx-),)
+  $(error pblx- has been removed. Please use pblb- instead.)
+endif
+
 targets += $(image-y) pbl.lds barebox.x barebox.z piggy.o
 targets += $(patsubst %,%.pblb,$(pblb-y))
 targets += $(patsubst %,%.pbl,$(pblb-y))
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] images: check for use of obsolete pblx-*

[Sascha Hauer]

On Mon, Jan 14, 2019 at 02:48:08PM +0100, Ahmad Fatoum wrote:
> pblx-* has been removed in 5a1a5ed253 ("ARM: images: use piggydata")
> and using it (e.g. because a patchset was rebased) results in a non-obvious:
> 
> 	make[1]: *** No rule to make target 'images/*.pblx.*', \
> 	needed by 'images/barebox-*.img'.  Stop.
> 
> Avoid this by explicitly failing with an error message whenever pblx-y
> or pblx- has been defined.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---

Hey, it just triggered in master ;)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox