From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1glcrG-0007p8-12 for barebox@lists.infradead.org; Mon, 21 Jan 2019 16:55:37 +0000 Received: by mail-qk1-x742.google.com with SMTP id w204so12651530qka.2 for ; Mon, 21 Jan 2019 08:55:33 -0800 (PST) Date: Mon, 21 Jan 2019 11:55:30 -0500 Message-ID: <20190121115530.GC3832@t480s.localdomain> From: Vivien Didelot In-Reply-To: References: <20190119005108.31747-1-vivien.didelot@gmail.com> MIME-Version: 1.0 Content-Disposition: inline List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] ARM: zii-vf610-dev: fix boot sd To: Andrey Smirnov Cc: Barebox List Hi Andrey, On Sat, 19 Jan 2019 12:39:45 -0800, Andrey Smirnov wrote: > On Fri, Jan 18, 2019 at 4:51 PM Vivien Didelot wrote: > > > > The 'sd' boot is currently broken on zii-vf610-dev because there are no > > mci devices (anymore?), only mmc. > > Yeah, I forgot to update this part in 5f99a8d403 "dts: VFxxx: Add > aliases for ESDHC controllers", sorry about that! No worries, I'll add a Fixes tag in v2, if Barebox likes that ;-) > > There are also no need to check > > for the device number since both Rev B and Rev C report their SD card > > slot on mmc1. > > > > I think you might be misreading the if condition in that check. What > it is meant to test is: > > if ((board == VF610 Dev Rev C) || (board == VF610 Dev Rev B)) { > SDHCI = SDHCI1 > } else { > SDHCI = SDHCI2 > } > > IOW, it is meant to configure development boards to boot from SD card > (attached to SDHCI1 on both revisions) and from eMMC on other boards > supported by that build (CFU1, SPU3, SCU4). OK I got confused because I didn't know that zii-vf610-dev was used by other platforms, I'll keep the check. > > Note that mmc1.0 is already mounted on /mnt/mmc1.0 once mmc1.probe=1 > > is typed. It would've been more appropriate to use "ln /mnt/mmc1.0 > > /mnt/sd", but ln isn't useable with automount since the mountpoint > > needs to be already created and ln has no force option. There are > > no complains with having two mountpoints for a device, so just blindly > > mount the device again. > > > > I think we can still take advantage of default automount path > (/mnt/mmc1.0), by moving the if check to "boot/sd" and using > "/mnt/mmc${global.sd}.0/" as a prefix for Linux image and DTB blob. > This way there would be no need to create a symlink or a second mount > point and "init/automount-sd" could be dropped completely. Will do, thank you. Vivien _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox