From: Sascha Hauer <s.hauer@pengutronix.de>
To: Vivien Didelot <vivien.didelot@gmail.com>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>, barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: zii-vf610-dev: fix boot from SD
Date: Tue, 22 Jan 2019 08:40:03 +0100 [thread overview]
Message-ID: <20190122074003.sclz4twikg3ykbqj@pengutronix.de> (raw)
In-Reply-To: <20190121175305.31674-1-vivien.didelot@gmail.com>
Hi Vivien,
On Mon, Jan 21, 2019 at 12:53:04PM -0500, Vivien Didelot wrote:
> VF610 Dev Rev B and VF610 Dev Rev C boot from SD card attached to
> SDHCI1, and CFU1, SPU3 and SCU4 boot from eMMC attached to SDHCI2.
>
> Since 5f99a8d40305 ("dts: VFxxx: Add aliases for ESDHC controllers"),
> these devices were renamed from mci0 and mci1 to mmc1 and mmc2.
>
> To fix this, completely drop the automount-sd script, probe mmcX from
> the boot/sd script directly and use the mountpoint /mnt/mmcX.0 from
> there. At the same time, make the sd variable non global.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>
> ---
> --- a/arch/arm/boards/zii-vf610-dev/defaultenv-zii-vf610-dev/init/automount-sd
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -#!/bin/sh
> -
> -if [ x${global.hostname} = xdev-rev-b -o x${global.hostname} = xdev-rev-c ];
> -then
> - global sd=0
> -else
> - global sd=1
> -fi
> -
> -mkdir -p /mnt/sd
> -automount /mnt/sd 'mci${global.sd}.probe=1 && mount /dev/disk${global.sd}.0 /mnt/sd'
Any special reason you evaluate $global.sd at the time the automount is
executed? I would expect a local variable here and the command put in
"" rather than ''
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-01-22 7:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 17:53 Vivien Didelot
2019-01-21 17:53 ` [PATCH 2/2] ARM: zii-vf610-dev: boot initrd " Vivien Didelot
2019-01-22 7:40 ` Sascha Hauer [this message]
2019-01-22 17:07 ` [PATCH 1/2] ARM: zii-vf610-dev: fix boot " Vivien Didelot
2019-01-22 17:20 ` Sascha Hauer
2019-01-23 0:48 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122074003.sclz4twikg3ykbqj@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox