From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] block: Do not write past block device boundary during a flush
Date: Tue, 22 Jan 2019 08:57:42 +0100 [thread overview]
Message-ID: <20190122075742.xbf4brm2465c4yvv@pengutronix.de> (raw)
In-Reply-To: <20190122060625.12337-1-andrew.smirnov@gmail.com>
On Mon, Jan 21, 2019 at 10:06:24PM -0800, Andrey Smirnov wrote:
> When calling I/O functions of underlying block device driver we always
> need to make sure that its size is small enough to not go past
> device's boundary. Not only in get_chunk() and block_cache(), but in
> writebuffer_flush() as well. Since the same code is used in three
> different places, move it into a subroutine and adjust all of the
> calls to ->write()/->read() accordingly.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> common/block.c | 22 +++++++++++++---------
> 1 file changed, 13 insertions(+), 9 deletions(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-01-22 7:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 6:06 Andrey Smirnov
2019-01-22 6:06 ` [PATCH 2/2] block: Move shared code in get_chunk() out of if statement Andrey Smirnov
2019-01-22 7:57 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122075742.xbf4brm2465c4yvv@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox