From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1glzj2-0006mL-EC for barebox@lists.infradead.org; Tue, 22 Jan 2019 17:20:38 +0000 Date: Tue, 22 Jan 2019 18:20:33 +0100 From: Sascha Hauer Message-ID: <20190122172032.ljfgfr7h2z5de3vf@pengutronix.de> References: <20190121175305.31674-1-vivien.didelot@gmail.com> <20190122074003.sclz4twikg3ykbqj@pengutronix.de> <20190122120702.GB27769@t480s.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190122120702.GB27769@t480s.localdomain> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/2] ARM: zii-vf610-dev: fix boot from SD To: Vivien Didelot Cc: Andrey Smirnov , barebox@lists.infradead.org On Tue, Jan 22, 2019 at 12:07:02PM -0500, Vivien Didelot wrote: > Hi Sascha, > > On Tue, 22 Jan 2019 08:40:03 +0100, Sascha Hauer wrote: > > On Mon, Jan 21, 2019 at 12:53:04PM -0500, Vivien Didelot wrote: > > > VF610 Dev Rev B and VF610 Dev Rev C boot from SD card attached to > > > SDHCI1, and CFU1, SPU3 and SCU4 boot from eMMC attached to SDHCI2. > > > > > > Since 5f99a8d40305 ("dts: VFxxx: Add aliases for ESDHC controllers"), > > > these devices were renamed from mci0 and mci1 to mmc1 and mmc2. > > > > > > To fix this, completely drop the automount-sd script, probe mmcX from > > > the boot/sd script directly and use the mountpoint /mnt/mmcX.0 from > > > there. At the same time, make the sd variable non global. > > > > > > Signed-off-by: Vivien Didelot > > > --- > > > --- a/arch/arm/boards/zii-vf610-dev/defaultenv-zii-vf610-dev/init/automount-sd > > > +++ /dev/null > > > @@ -1,13 +0,0 @@ > > > -#!/bin/sh > > > - > > > -if [ x${global.hostname} = xdev-rev-b -o x${global.hostname} = xdev-rev-c ]; > > > -then > > > - global sd=0 > > > -else > > > - global sd=1 > > > -fi > > > - > > > -mkdir -p /mnt/sd > > > -automount /mnt/sd 'mci${global.sd}.probe=1 && mount /dev/disk${global.sd}.0 /mnt/sd' > > > > Any special reason you evaluate $global.sd at the time the automount is > > executed? I would expect a local variable here and the command put in > > "" rather than '' > > I'm not sure to understand your question. As stated in the commit > message, this patch gets rid of this automount script and use a local > variable 'sd' in the boot/sd script instead. D'oh. You're removing this file, not adding it. Forget my comment. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox