mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ls: Adjust amount of space allocated for filesize
Date: Thu, 24 Jan 2019 08:24:28 +0100	[thread overview]
Message-ID: <20190124072428.h2yykh6lrfmra7j2@pengutronix.de> (raw)
In-Reply-To: <20190118004113.20740-1-andrew.smirnov@gmail.com>

On Thu, Jan 17, 2019 at 04:41:13PM -0800, Andrey Smirnov wrote:
> Maximum file size on 64-bit system is 2^63-1 (9223372036854775807),
> which takes more that 14 characters of space. In order to keep things
> properly aligned adjust that spacing to 20 on 64-bit platforms.
> 
> Before:
> 
> ls -l /dev/
> d---------              0 .
> d---------              0 ..
> crw-------          16384 dds-eeprom
> crw-------            256 e1000-invm0
> crw-------          16384 eeprom0
> cr--------              0 full
> crw-------           2048 imx-ocotp
> crw-------          16384 main-eeprom
> crw-------             64 mdio0-phy00
> crw------- 9223372036854775807 mem
> c-w-------              0 netconsole-1
> c-w-------              0 null
> crw-------   256060514304 nvme0n1
> cr--------              0 prng
> crw-------     4294967296 ram0
> c-w-------              0 serial0-1
> cr--------              0 zero
> 
> After:
> 
> ls -l /dev/
> d---------                   0 .
> d---------                   0 ..
> crw-------               16384 dds-eeprom
> crw-------                 256 e1000-invm0
> crw-------               16384 eeprom0
> cr--------                   0 full
> crw-------                2048 imx-ocotp
> crw-------               16384 main-eeprom
> crw-------                  64 mdio0-phy00
> crw------- 9223372036854775807 mem
> c-w-------                   0 netconsole-1
> c-w-------                   0 null
> crw-------        256060514304 nvme0n1
> cr--------                   0 prng
> crw-------          4294967296 ram0
> c-w-------                   0 serial0-1
> cr--------                   0 zero
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  commands/ls.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2019-01-24  7:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-18  0:41 Andrey Smirnov
2019-01-24  7:24 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190124072428.h2yykh6lrfmra7j2@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox