[PATCH] gen-dtb-s: annotate magic values with their meaning

[PATCH] gen-dtb-s: annotate magic values with their meaning

[Uwe Kleine-König]

This helps understand how the imd stuff works because now
$(git grep IMD_TYPE_OF_COMPATIBLE) also matches the critical code
location that creates the imd entry.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 scripts/gen-dtb-s | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/gen-dtb-s b/scripts/gen-dtb-s
index 4215461edb3c..2b44ffb361eb 100755
--- a/scripts/gen-dtb-s
+++ b/scripts/gen-dtb-s
@@ -25,7 +25,7 @@ if [ "$imd" = "y" ]; then
 	if [ "$compat" != "notfound" ]; then
 
 		compatlen=$($FDTGET -t s "$dtb" / compatible | wc -c)
-		le32 0x640c8005
+		le32 0x640c8005 # IMD_TYPE_OF_COMPATIBLE
 		le32 $compatlen
 		echo ".byte " $compat
 		echo ".balign 4"
@@ -35,7 +35,7 @@ if [ "$imd" = "y" ]; then
 
 	if [ "$model" != "notfound" ]; then
 		modellen=$($FDTGET -t s "$dtb" / model | wc -c)
-		le32 0x640c8004
+		le32 0x640c8004 # IMD_TYPE_MODEL
 		le32 $modellen
 		echo ".byte " $model
 		echo ".balign 4"
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] gen-dtb-s: annotate magic values with their meaning

[Sascha Hauer]

On Fri, Jan 25, 2019 at 09:35:04PM +0100, Uwe Kleine-König wrote:
> This helps understand how the imd stuff works because now
> $(git grep IMD_TYPE_OF_COMPATIBLE) also matches the critical code
> location that creates the imd entry.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  scripts/gen-dtb-s | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/scripts/gen-dtb-s b/scripts/gen-dtb-s
> index 4215461edb3c..2b44ffb361eb 100755
> --- a/scripts/gen-dtb-s
> +++ b/scripts/gen-dtb-s
> @@ -25,7 +25,7 @@ if [ "$imd" = "y" ]; then
>  	if [ "$compat" != "notfound" ]; then
>  
>  		compatlen=$($FDTGET -t s "$dtb" / compatible | wc -c)
> -		le32 0x640c8005
> +		le32 0x640c8005 # IMD_TYPE_OF_COMPATIBLE
>  		le32 $compatlen
>  		echo ".byte " $compat
>  		echo ".balign 4"
> @@ -35,7 +35,7 @@ if [ "$imd" = "y" ]; then
>  
>  	if [ "$model" != "notfound" ]; then
>  		modellen=$($FDTGET -t s "$dtb" / model | wc -c)
> -		le32 0x640c8004
> +		le32 0x640c8004 # IMD_TYPE_MODEL
>  		le32 $modellen
>  		echo ".byte " $model
>  		echo ".balign 4"
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox