From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] ARM: aarch64: Avoid relocations in runtime-offset.S
Date: Fri, 1 Feb 2019 07:40:40 +0100 [thread overview]
Message-ID: <20190201064040.2ygmhlwm3vmua73y@pengutronix.de> (raw)
In-Reply-To: <20190130013050.3834-1-andrew.smirnov@gmail.com>
On Tue, Jan 29, 2019 at 05:30:50PM -0800, Andrey Smirnov wrote:
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
Applied, thanks
Sascha
>
> Changes since [v1]:
>
> - Added a comment explaining the reasoning "a" specifier is
> missing
>
> [v1] http://lists.infradead.org/pipermail/barebox/2019-January/036779.html
>
> arch/arm/lib64/runtime-offset.S | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/lib64/runtime-offset.S b/arch/arm/lib64/runtime-offset.S
> index 177ca6478..6624fdfa1 100644
> --- a/arch/arm/lib64/runtime-offset.S
> +++ b/arch/arm/lib64/runtime-offset.S
> @@ -1,7 +1,19 @@
> #include <linux/linkage.h>
> #include <asm/assembler.h>
>
> -.section ".text_bare_init","ax"
> +/*
> + * The .section directive below intentionally omits "a", since that
> + * appears to be the simplest way to force assembler to not generate
> + * R_AARCH64_RELATIVE relocation for
> + *
> + * linkadr:
> + * .quad get_runtime_offset
> + *
> + * statement below. While having that relocating was relatively
> + * harmless with GCC8, builging the code with GCC5 resulted in
> + * "linkaddr" being initialized to 0 causing complete boot breakdown
> + */
> +.section ".text_bare_init","x"
>
> /*
> * Get the offset between the link address and the address
> --
> 2.20.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-02-01 6:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 1:30 Andrey Smirnov
2019-02-01 6:40 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201064040.2ygmhlwm3vmua73y@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox