From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: barebox@lists.infradead.org, Christian Hemp <christian.hemp@posteo.de>
Subject: Re: [PATCH] ARM: phyCORE-i.MX8M SOM support
Date: Wed, 13 Feb 2019 07:14:59 +0100 [thread overview]
Message-ID: <20190213061459.fp643qeqyk447ddo@pengutronix.de> (raw)
In-Reply-To: <1549882858.2546.3.camel@pengutronix.de>
Hi Christian,
On Mon, Feb 11, 2019 at 12:00:58PM +0100, Lucas Stach wrote:
> Hi Christian,
>
> Am Mittwoch, den 06.02.2019, 19:41 +0100 schrieb Christian Hemp:
> > The phyCORE-i.MX8M aka PCL-066 is a SoM containing a i.MX8M SoC.
> >
> > phyCORE-i.MX8M:
> > - 1GB LPDDR4 RAM
> > - eMMC
> > - microSD
> > - Ethernet
> >
> > Signed-off-by: Christian Hemp <christian.hemp@posteo.de>
> > ---
> > arch/arm/boards/Makefile | 1 +
> > arch/arm/boards/phytec-som-imx8m/.gitignore | 1 +
> > arch/arm/boards/phytec-som-imx8m/Makefile | 2 +
> > arch/arm/boards/phytec-som-imx8m/board.c | 55 +
> > arch/arm/boards/phytec-som-imx8m/ddr.h | 28 +
> > arch/arm/boards/phytec-som-imx8m/ddr_init.c | 225 +++++
> > .../boards/phytec-som-imx8m/ddrphy_train.c | 947 ++++++++++++++++++
> > .../flash-header-phycore-imx8mq.imxcfg | 5 +
> > arch/arm/boards/phytec-som-imx8m/lowlevel.c | 127 +++
> > arch/arm/configs/imx_v8_defconfig | 2 +
> > arch/arm/dts/Makefile | 1 +
> > arch/arm/dts/imx8mq-phytec-phycore-som.dts | 328 ++++++
> > arch/arm/mach-imx/Kconfig | 7 +
> > images/Makefile.imx | 5 +
> > 14 files changed, 1734 insertions(+)
> > create mode 100644 arch/arm/boards/phytec-som-imx8m/.gitignore
> > create mode 100644 arch/arm/boards/phytec-som-imx8m/Makefile
> > create mode 100644 arch/arm/boards/phytec-som-imx8m/board.c
> > create mode 100644 arch/arm/boards/phytec-som-imx8m/ddr.h
> > create mode 100644 arch/arm/boards/phytec-som-imx8m/ddr_init.c
> > create mode 100644 arch/arm/boards/phytec-som-imx8m/ddrphy_train.c
> > create mode 100644 arch/arm/boards/phytec-som-imx8m/flash-header-phycore-imx8mq.imxcfg
> > create mode 100644 arch/arm/boards/phytec-som-imx8m/lowlevel.c
> > create mode 100644 arch/arm/dts/imx8mq-phytec-phycore-som.dts
>
> The other supported i.MX8M boards are using a "imx8mq" name tag. I
> would really like to see some consistency here, as the i.MX8 naming in
> general is already confusing in itself, so we shouldn't add to this
> confusion by calling the same SoC both mx8m and mx8mq.
I tested your patch and needed following changes to make it work with
latest barebox:
diff --git a/arch/arm/boards/phytec-som-imx8m/ddr.h b/arch/arm/boards/phytec-som-imx8m/ddr.h
index 7d195e6002..58a1c91be3 100644
--- a/arch/arm/boards/phytec-som-imx8m/ddr.h
+++ b/arch/arm/boards/phytec-som-imx8m/ddr.h
@@ -20,9 +20,8 @@
void phytec_imx8mq_phycore_ddr_init(void);
void phytec_imx8mq_phycore_ddr_cfg_phy(void);
-#define FW_1D_IMAGE imx_lpddr4_pmu_train_1d_imem_bin, \
- imx_lpddr4_pmu_train_1d_dmem_bin
-#define FW_2D_IMAGE imx_lpddr4_pmu_train_2d_imem_bin, \
- imx_lpddr4_pmu_train_2d_dmem_bin
-
+#define FW_1D_IMAGE lpddr4_pmu_train_1d_imem_bin, \
+ lpddr4_pmu_train_1d_dmem_bin
+#define FW_2D_IMAGE lpddr4_pmu_train_2d_imem_bin, \
+ lpddr4_pmu_train_2d_dmem_bin
diff --git a/arch/arm/boards/phytec-som-imx8m/flash-header-phycore-imx8mq.imxcfg b/arch/arm/boards/phytec-som-imx8m/flash-header-phycore-imx8mq.imxcfg
index aff8321b9a..eabc9426c7 100644
--- a/arch/arm/boards/phytec-som-imx8m/flash-header-phycore-imx8mq.imxcfg
+++ b/arch/arm/boards/phytec-som-imx8m/flash-header-phycore-imx8mq.imxcfg
@@ -3,3 +3,4 @@ soc imx8mq
loadaddr 0x007E1000
max_load_size 0x3F000
dcdofs 0x400
+signed_hdmi_firmware firmware/signed_hdmi_imx8m.bin
diff --git a/arch/arm/boards/phytec-som-imx8m/lowlevel.c b/arch/arm/boards/phytec-som-imx8m/lowlevel.c
index 4a1054a5eb..bd13fd1860 100644
--- a/arch/arm/boards/phytec-som-imx8m/lowlevel.c
+++ b/arch/arm/boards/phytec-som-imx8m/lowlevel.c
@@ -115,7 +115,7 @@ ENTRY_FUNCTION(start_phytec_phycore_imx8mq, r0, r1, r2)
const u8 *bl31;
size_t bl31_size;
- get_builtin_firmware(imx_imx8m_bl31_bin, &bl31, &bl31_size);
+ get_builtin_firmware(imx8mq_bl31_bin, &bl31, &bl31_size);
imx8mq_atf_load_bl31(bl31, bl31_size);
}
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-02-13 6:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 18:41 Christian Hemp
2019-02-07 1:20 ` Andrey Smirnov
2019-02-11 8:20 ` Sascha Hauer
2019-02-11 11:00 ` Lucas Stach
2019-02-13 6:14 ` Oleksij Rempel [this message]
2019-02-14 18:20 ` Christian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213061459.fp643qeqyk447ddo@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=christian.hemp@posteo.de \
--cc=l.stach@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox